Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2460243002: blink: Cleanup Document.h class forward declarations (Closed)

Created:
4 years, 1 month ago by jbriance
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Cleanup Document.h class forward declarations Cosmetic change removing useless class forward declarations in Document.h, and adding missing ones in Element.h and AXObjectCache.h BUG=none Committed: https://crrev.com/cf77954a9e70a6dad236883376b919acab9461d2 Cr-Commit-Position: refs/heads/master@{#428690}

Patch Set 1 #

Patch Set 2 : Add missing class forward decl in AXObjectCache.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Source/core/dom/AXObjectCache.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 6 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
jbriance
4 years, 1 month ago (2016-10-30 18:02:23 UTC) #2
haraken
LGTM
4 years, 1 month ago (2016-10-30 18:02:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460243002/1
4 years, 1 month ago (2016-10-30 18:04:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/327432)
4 years, 1 month ago (2016-10-30 18:20:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460243002/20001
4 years, 1 month ago (2016-10-31 12:24:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 12:28:26 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cf77954a9e70a6dad236883376b919acab9461d2 Cr-Commit-Position: refs/heads/master@{#428690}
4 years, 1 month ago (2016-10-31 12:30:33 UTC) #19
jbriance
4 years, 1 month ago (2016-11-03 22:15:24 UTC) #20
Message was sent while issue was closed.
Meta bug created: https://bugs.chromium.org/p/chromium/issues/detail?id=662195

Powered by Google App Engine
This is Rietveld 408576698