[inspector] added Debugger.getPossibleBreakpoints method

[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to passed script, compiles debug code for SFI in range if needed and returns possible break locations.

BUG=chromium:566801
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/f0fb65838692071c5b86f272bbed07277d4a9295
Cr-Commit-Position: refs/heads/master@{#40783}

[kozy, 2016-10-31 21:16:04]

Description was changed from

==========
[WIP] [inspector] added Debugger.getPossibleBreakpoints method

BUG=
==========

to

==========
[inspector] added Debugger.getPossibleBreakpoints method

BUG=
==========

[kozy, 2016-11-01 01:26:23]

Description was changed from

==========
[inspector] added Debugger.getPossibleBreakpoints method

BUG=
==========

to

==========
[inspector] added Debugger.getPossibleBreakpoints method

BUG=chromium:566801
==========

[kozy, 2016-11-01 01:26:23]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org, yangguo@chromium.org

[kozy, 2016-11-01 01:27:31]

Description was changed from

==========
[inspector] added Debugger.getPossibleBreakpoints method

BUG=chromium:566801
==========

to

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
==========

[kozy, 2016-11-01 01:27:53]

Dmitry, please take a look.

[Yang, 2016-11-02 13:51:16]

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug-interfa...
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug-interfa...
src/debug/debug-interface.h:180: int Offset(int line, int column) const;
Can we have a nicer name? GetSourcePosition maybe?

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:1374: BytecodeArrayBreakIterator it(debug_info,
ALL_BREAK_LOCATIONS);
This is just duplicate code. Can we either use virtual methods or templates to
avoid that?

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:1398: if (!candidate) break;
this seems redundant.

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:1406: AllowHeapAllocation allow_before_return;
This is not safe. Once GC happens, the weak fixed array iterator can get into an
inconsistent state. If we simply exit the loop after this, it's fine. But we
actually may continue here.

Can we simply do something like this:

1. collect all shared function infos in the source range
2. ensure that these shared function infos are all compiled, if not, compile,
and repeat from 1.
3. collect break point locations from shared function infos collected in 1.

[kozy, 2016-11-03 01:15:02]

All done, please take another look.

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug-interfa...
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug-interfa...
src/debug/debug-interface.h:180: int Offset(int line, int column) const;
On 2016/11/02 13:51:15, Yang wrote:
> Can we have a nicer name? GetSourcePosition maybe?

Done.

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:1374: BytecodeArrayBreakIterator it(debug_info,
ALL_BREAK_LOCATIONS);
On 2016/11/02 13:51:15, Yang wrote:
> This is just duplicate code. Can we either use virtual methods or templates to
> avoid that?

Done.

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:1398: if (!candidate) break;
On 2016/11/02 13:51:15, Yang wrote:
> this seems redundant.

Removed.

https://codereview.chromium.org/2465553003/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:1406: AllowHeapAllocation allow_before_return;
On 2016/11/02 13:51:15, Yang wrote:
> This is not safe. Once GC happens, the weak fixed array iterator can get into
an
> inconsistent state. If we simply exit the loop after this, it's fine. But we
> actually may continue here.
> 
> Can we simply do something like this:
> 
> 1. collect all shared function infos in the source range
> 2. ensure that these shared function infos are all compiled, if not, compile,
> and repeat from 1.
> 3. collect break point locations from shared function infos collected in 1.

Thank you!
Done.

[Yang, 2016-11-03 08:03:26]

https://codereview.chromium.org/2465553003/diff/40001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/40001/src/api.cc#newcode8931
src/api.cc:8931: std::vector<int>& positions) const {
Can we use std::pair<int, int> or a struct to wrap line/column pairs in the
result and in general?

https://codereview.chromium.org/2465553003/diff/40001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2465553003/diff/40001/src/debug/debug.cc#newc...
src/debug/debug.cc:1373: std::vector<int>& positions) {
I've seen you do this elsewhere, but maybe we should change this: Google style
guide suggests not to use reference arguments unless it's const.
https://google.github.io/styleguide/cppguide.html#Reference_Arguments

https://codereview.chromium.org/2465553003/diff/40001/src/debug/debug.cc#newc...
src/debug/debug.cc:1395: Handle<FixedArray> candidates =
Can we simply use a List<Handle<>> here?

https://codereview.chromium.org/2465553003/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2465553003/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:409: positions.size() % 2) {
We would not have to check this if positions contained line/column structs or
pairs to begin with.

[kozy, 2016-11-03 17:26:45]

All done, please take another look.

https://codereview.chromium.org/2465553003/diff/40001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/40001/src/api.cc#newcode8931
src/api.cc:8931: std::vector<int>& positions) const {
On 2016/11/03 08:03:26, Yang wrote:
> Can we use std::pair<int, int> or a struct to wrap line/column pairs in the
> result and in general?

Replaced with Location object. I can convert it into struct if you think that
class is too much for this.

https://codereview.chromium.org/2465553003/diff/40001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2465553003/diff/40001/src/debug/debug.cc#newc...
src/debug/debug.cc:1373: std::vector<int>& positions) {
On 2016/11/03 08:03:26, Yang wrote:
> I've seen you do this elsewhere, but maybe we should change this: Google style
> guide suggests not to use reference arguments unless it's const.
> https://google.github.io/styleguide/cppguide.html#Reference_Arguments

Changed to pointer.

https://codereview.chromium.org/2465553003/diff/40001/src/debug/debug.cc#newc...
src/debug/debug.cc:1395: Handle<FixedArray> candidates =
On 2016/11/03 08:03:26, Yang wrote:
> Can we simply use a List<Handle<>> here?

Done.

https://codereview.chromium.org/2465553003/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2465553003/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:409: positions.size() % 2) {
On 2016/11/03 08:03:26, Yang wrote:
> We would not have to check this if positions contained line/column structs or
> pairs to begin with.

Removed.

[dgozman, 2016-11-03 21:13:13]

Everything except debug.cc (where I don't understand 90% of the code) lgtm.

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc#newcode8954
src/api.cc:8954: while (offset > line_endings[current_line_end_index] &&
while (offset > ...) {
  index++;
  CHECK(index < )
}

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc#newcode8969
src/api.cc:8969: std::vector<int> line_endings = LineEnds();
Can we cache line endings?

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc#newcode9007
src/api.cc:9007: int DebugInterface::Script::Location::GetColumnNumber() const {
where are the empty lines?

https://codereview.chromium.org/2465553003/diff/60001/src/debug/debug-interfa...
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2465553003/diff/60001/src/debug/debug-interfa...
src/debug/debug-interface.h:152: class Location {
Move this outside of Script. We can also turn this into struct.

https://codereview.chromium.org/2465553003/diff/60001/src/debug/debug-interfa...
src/debug/debug-interface.h:183: * lines and columns are 0-based.
This comment should be in Location.

https://codereview.chromium.org/2465553003/diff/60001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2465553003/diff/60001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:423: using protocol::Debugger::Location;
Please remove.

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints.js (right):

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints.js:12: * - collected script
Remove?

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints.js:91: // TODO(kozyatinskiy):
where pauses before foo3 and foo4 calls?!
?!?!!11!111!!!?

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints.js:139: if (id_data[1] * 1 !==
message.result.actualLocation.lineNumber || id_data[2] * 1 !==
message.result.actualLocation.columnNumber) {
parseInt

[kozy, 2016-11-03 22:17:13]

all done, thanks!!11!!

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc#newcode8954
src/api.cc:8954: while (offset > line_endings[current_line_end_index] &&
On 2016/11/03 21:13:12, dgozman wrote:
> while (offset > ...) {
>   index++;
>   CHECK(index < )
> }

Done.

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc#newcode8969
src/api.cc:8969: std::vector<int> line_endings = LineEnds();
On 2016/11/03 21:13:12, dgozman wrote:
> Can we cache line endings?

Done.

https://codereview.chromium.org/2465553003/diff/60001/src/api.cc#newcode9007
src/api.cc:9007: int DebugInterface::Script::Location::GetColumnNumber() const {
On 2016/11/03 21:13:12, dgozman wrote:
> where are the empty lines?

Done.

https://codereview.chromium.org/2465553003/diff/60001/src/debug/debug-interfa...
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2465553003/diff/60001/src/debug/debug-interfa...
src/debug/debug-interface.h:152: class Location {
On 2016/11/03 21:13:13, dgozman wrote:
> Move this outside of Script. We can also turn this into struct.

Moved.

https://codereview.chromium.org/2465553003/diff/60001/src/debug/debug-interfa...
src/debug/debug-interface.h:183: * lines and columns are 0-based.
On 2016/11/03 21:13:13, dgozman wrote:
> This comment should be in Location.

Removed.

https://codereview.chromium.org/2465553003/diff/60001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2465553003/diff/60001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:423: using protocol::Debugger::Location;
On 2016/11/03 21:13:13, dgozman wrote:
> Please remove.

Done.

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints.js (right):

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints.js:12: * - collected script
On 2016/11/03 21:13:13, dgozman wrote:
> Remove?

Removed.

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints.js:91: // TODO(kozyatinskiy):
where pauses before foo3 and foo4 calls?!
On 2016/11/03 21:13:13, dgozman wrote:
> ?!?!!11!111!!!?

Removed.

https://codereview.chromium.org/2465553003/diff/60001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints.js:139: if (id_data[1] * 1 !==
message.result.actualLocation.lineNumber || id_data[2] * 1 !==
message.result.actualLocation.columnNumber) {
On 2016/11/03 21:13:13, dgozman wrote:
> parseInt

Done.

[Yang, 2016-11-04 12:22:58]

LGTM with comments addressed.

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8932
src/api.cc:8932: return array->GetValueChecked<i::Smi>(isolate, index)->value();
Let's just use Smi::cast(array->get(index))->value()

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8937
src/api.cc:8937: const Location& start, const Location& end,
Is this location with or without the line_offset and column_offset? If I'm not
mistaken, the line_ends array operates without offsets.

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8951
src/api.cc:8951: if (end.IsEmpty())
can we have brackets around the then-body and the else-body?

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8957
src/api.cc:8957: std::vector<int> offsets;
why don't we pass an std::set to GetPossibleBreakpoints directly?

https://codereview.chromium.org/2465553003/diff/80001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2465553003/diff/80001/src/debug/debug.cc#newc...
src/debug/debug.cc:1357: void GetBreakablePositions(Iterator& it, int
start_position, int end_position,
The iterator is still passed by &-reference.

[kozy, 2016-11-04 14:48:38]

all done, thank you!

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8932
src/api.cc:8932: return array->GetValueChecked<i::Smi>(isolate, index)->value();
On 2016/11/04 12:22:58, Yang wrote:
> Let's just use Smi::cast(array->get(index))->value()

Done.

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8937
src/api.cc:8937: const Location& start, const Location& end,
On 2016/11/04 12:22:58, Yang wrote:
> Is this location with or without the line_offset and column_offset? If I'm not
> mistaken, the line_ends array operates without offsets.

This Location contains line_offset and column_offset in source, we addressed all
location this way in inspector. To convert it to offset I use
DebugInterface::Script::GetSourcePosition using line endings.

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8951
src/api.cc:8951: if (end.IsEmpty())
On 2016/11/04 12:22:58, Yang wrote:
> can we have brackets around the then-body and the else-body?

Done.

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8957
src/api.cc:8957: std::vector<int> offsets;
On 2016/11/04 12:22:58, Yang wrote:
> why don't we pass an std::set to GetPossibleBreakpoints directly?

Done.

https://codereview.chromium.org/2465553003/diff/80001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2465553003/diff/80001/src/debug/debug.cc#newc...
src/debug/debug.cc:1357: void GetBreakablePositions(Iterator& it, int
start_position, int end_position,
On 2016/11/04 12:22:58, Yang wrote:
> The iterator is still passed by &-reference.

Done.

[kozy, 2016-11-04 14:48:45]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 14:48:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-11-04 14:48:56]

Description was changed from

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
==========

to

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[kozy, 2016-11-04 14:49:02]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-11-04 14:49:07]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 14:49:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-11-04 14:53:00]

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8937
src/api.cc:8937: const Location& start, const Location& end,
On 2016/11/04 14:48:38, kozyatinskiy wrote:
> On 2016/11/04 12:22:58, Yang wrote:
> > Is this location with or without the line_offset and column_offset? If I'm
not
> > mistaken, the line_ends array operates without offsets.
> 
> This Location contains line_offset and column_offset in source, we addressed
all
> location this way in inspector. To convert it to offset I use
> DebugInterface::Script::GetSourcePosition using line endings.

yes, but arent line_ends initialized without offset? so the conversion is wrong?

[kozy, 2016-11-04 15:04:01]

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8937
src/api.cc:8937: const Location& start, const Location& end,
On 2016/11/04 14:53:00, Yang wrote:
> On 2016/11/04 14:48:38, kozyatinskiy wrote:
> > On 2016/11/04 12:22:58, Yang wrote:
> > > Is this location with or without the line_offset and column_offset? If I'm
> not
> > > mistaken, the line_ends array operates without offsets.
> > 
> > This Location contains line_offset and column_offset in source, we addressed
> all
> > location this way in inspector. To convert it to offset I use
> > DebugInterface::Script::GetSourcePosition using line endings.
> 
> yes, but arent line_ends initialized without offset? so the conversion is
wrong?

As I found line_ends contains offset of \n in source as just offset with offset
of EOF.
In case of:
var a = 1;\n
var b = 2;\n

It will be something like [ 11, 23, 24 ].

Test that is added in this CL cover all branches in conversion and I think it's
right, but maybe I'm still misunderstanding something.

[Yang, 2016-11-04 15:08:07]

On 2016/11/04 15:04:01, kozyatinskiy wrote:
> https://codereview.chromium.org/2465553003/diff/80001/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/2465553003/diff/80001/src/api.cc#newcode8937
> src/api.cc:8937: const Location& start, const Location& end,
> On 2016/11/04 14:53:00, Yang wrote:
> > On 2016/11/04 14:48:38, kozyatinskiy wrote:
> > > On 2016/11/04 12:22:58, Yang wrote:
> > > > Is this location with or without the line_offset and column_offset? If
I'm
> > not
> > > > mistaken, the line_ends array operates without offsets.
> > > 
> > > This Location contains line_offset and column_offset in source, we
addressed
> > all
> > > location this way in inspector. To convert it to offset I use
> > > DebugInterface::Script::GetSourcePosition using line endings.
> > 
> > yes, but arent line_ends initialized without offset? so the conversion is
> wrong?
> 
> As I found line_ends contains offset of \n in source as just offset with
offset
> of EOF.
> In case of:
> var a = 1;\n
> var b = 2;\n
> 
> It will be something like [ 11, 23, 24 ].
> 
> Test that is added in this CL cover all branches in conversion and I think
it's
> right, but maybe I'm still misunderstanding something.

line_offset and column_offset are properties on v8::internal::Script to account
for the offsets in the script. For example, if the script is from an inline
script in an html file, the line and column offset point to the end of the
<script> opening tag. V8 has to convert the offset from ones containing this to
ones that do not. V8 uses the latter internally, but I suspect that devtools
uses the former. Grep for WITH_OFFSET.

[commit-bot: I haz the power, 2016-11-04 15:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 15:35:16]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[kozy, 2016-11-04 16:38:50]

On 2016/11/04 15:08:07, Yang wrote:

> line_offset and column_offset are properties on v8::internal::Script to
account
> for the offsets in the script. For example, if the script is from an inline
> script in an html file, the line and column offset point to the end of the
> <script> opening tag. V8 has to convert the offset from ones containing this
to
> ones that do not. V8 uses the latter internally, but I suspect that devtools
> uses the former. Grep for WITH_OFFSET.

Thanks a lot! Fixed and added a test.

[kozy, 2016-11-04 16:40:47]

Dmitry, please take a look on inspector-test.cc

[kozy, 2016-11-04 17:29:10]

I updated compileAndRunWithOrigin and implemented InspectorTest.addScript with
this.
Dmitry, please take a look.

[dgozman, 2016-11-04 18:26:49]

lgtm

https://codereview.chromium.org/2465553003/diff/150016/test/inspector/task-ru...
File test/inspector/task-runner.h (right):

https://codereview.chromium.org/2465553003/diff/150016/test/inspector/task-ru...
test/inspector/task-runner.h:72: explicit ExecuteStringTask(const
v8::internal::Vector<uint16_t>& expression,
No explicit.

[kozy, 2016-11-04 18:49:43]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 18:49:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-11-04 18:50:30]

all done, thanks.

https://codereview.chromium.org/2465553003/diff/150016/test/inspector/task-ru...
File test/inspector/task-runner.h (right):

https://codereview.chromium.org/2465553003/diff/150016/test/inspector/task-ru...
test/inspector/task-runner.h:72: explicit ExecuteStringTask(const
v8::internal::Vector<uint16_t>& expression,
On 2016/11/04 18:26:49, dgozman wrote:
> No explicit.

Done.

[commit-bot: I haz the power, 2016-11-04 19:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:45:09]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-11-04 19:57:07]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-04 19:57:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2465553003/#ps90013
(title: "addressed comments")

[commit-bot: I haz the power, 2016-11-04 19:57:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:59:15]

Description was changed from

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-11-04 19:59:17]

Committed patchset #10 (id:90013)

[commit-bot: I haz the power, 2016-11-17 22:23:47]

Description was changed from

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[inspector] added Debugger.getPossibleBreakpoints method

This method iterates through all shared function info which are related to
passed script, compiles debug code for SFI in range if needed and returns
possible break locations.

BUG=chromium:566801
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/f0fb65838692071c5b86f272bbed07277d4a9295
Cr-Commit-Position: refs/heads/master@{#40783}
==========

[commit-bot: I haz the power, 2016-11-17 22:23:49]

Patchset 10 (id:??) landed as
https://crrev.com/f0fb65838692071c5b86f272bbed07277d4a9295
Cr-Commit-Position: refs/heads/master@{#40783}