Issue 2482513002: [inspector] use debuggerContext as current in getPossibleBreakpoints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2482513002: [inspector] use debuggerContext as current in getPossibleBreakpoints (Closed)

Created:
4 years, 1 month ago by kozy

Modified:
4 years, 1 month ago

Reviewers:
dgozman

CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[inspector] use debuggerContext as current in getPossibleBreakpoints getPossibleBreakpoints can lead to code compilation. Compiler requires current context to allocate array contants. BUG=none R=dgozman@chromium.org

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -3 lines)			Patch
M	src/inspector/v8-debugger-agent-impl.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	test/inspector/debugger/get-possible-breakpoints.js	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	test/inspector/debugger/get-possible-breakpoints-expected.txt	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2465553003 Patch 90013

Messages

Total messages: 5 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kozy

4 years, 1 month ago (2016-11-04 21:33:23 UTC) #1

Dmitry, please take a look.

I'd like to use debuggerContext here before we found better solution to fix a
crash and continue work on inline breakpoints.
I'll figure out better way how to manage this case in the same CL where I move
setBreakpoint methods to new debug-interface after discussion with Yang.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages