Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: src/inspector/v8-debugger-script.cc

Issue 2465553003: [inspector] added Debugger.getPossibleBreakpoints method (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | test/inspector/debugger/get-possible-breakpoints.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-script.cc
diff --git a/src/inspector/v8-debugger-script.cc b/src/inspector/v8-debugger-script.cc
index 2da169c8323ce44a81bfd7a1435ad21386235b51..ed0c0d63de50c6c69cd7ab970ae5155ad6e0dbf0 100644
--- a/src/inspector/v8-debugger-script.cc
+++ b/src/inspector/v8-debugger-script.cc
@@ -70,6 +70,7 @@ static String16 calculateHash(const String16& str) {
V8DebuggerScript::V8DebuggerScript(v8::Isolate* isolate,
v8::Local<v8::DebugInterface::Script> script,
bool isLiveEdit) {
+ m_isolate = script->GetIsolate();
m_id = String16::fromInteger(script->Id());
v8::Local<v8::String> tmp;
if (script->Name().ToLocal(&tmp)) m_url = toProtocolString(tmp);
@@ -113,8 +114,9 @@ V8DebuggerScript::V8DebuggerScript(v8::Isolate* isolate,
}
m_isLiveEdit = isLiveEdit;
+
if (script->Source().ToLocal(&tmp)) {
- m_source.Reset(isolate, tmp);
+ m_source.Reset(m_isolate, tmp);
String16 source = toProtocolString(tmp);
m_hash = calculateHash(source);
// V8 will not count last line if script source ends with \n.
@@ -123,6 +125,8 @@ V8DebuggerScript::V8DebuggerScript(v8::Isolate* isolate,
m_endColumn = 0;
}
}
+
+ m_script.Reset(m_isolate, script);
}
V8DebuggerScript::~V8DebuggerScript() {}
@@ -143,10 +147,18 @@ void V8DebuggerScript::setSourceMappingURL(const String16& sourceMappingURL) {
m_sourceMappingURL = sourceMappingURL;
}
-void V8DebuggerScript::setSource(v8::Isolate* isolate,
- v8::Local<v8::String> source) {
- m_source.Reset(isolate, source);
+void V8DebuggerScript::setSource(v8::Local<v8::String> source) {
+ m_source.Reset(m_isolate, source);
m_hash = calculateHash(toProtocolString(source));
}
+bool V8DebuggerScript::getPossibleBreakpoints(
+ const v8::DebugInterface::Location& start,
+ const v8::DebugInterface::Location& end,
+ std::vector<v8::DebugInterface::Location>* locations) {
+ v8::HandleScope scope(m_isolate);
+ v8::Local<v8::DebugInterface::Script> script = m_script.Get(m_isolate);
+ return script->GetPossibleBreakpoints(start, end, locations);
+}
+
} // namespace v8_inspector
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | test/inspector/debugger/get-possible-breakpoints.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698