Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: src/debug/debug.cc

Issue 2465553003: [inspector] added Debugger.getPossibleBreakpoints method (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug-interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index b3d8347cfd32171d95b40b55b3703532bfa46d37..6564726830609bc65d9ade701c8f3ba007064ff9 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -1352,6 +1352,84 @@ bool Debug::PrepareFunctionForBreakPoints(Handle<SharedFunctionInfo> shared) {
return true;
}
+namespace {
+template <typename Iterator>
+void GetBreakablePositions(Iterator* it, int start_position, int end_position,
+ BreakPositionAlignment alignment,
+ std::set<int>* positions) {
+ it->SkipToPosition(start_position, alignment);
+ while (!it->Done() && it->position() < end_position &&
+ it->position() >= start_position) {
+ positions->insert(alignment == STATEMENT_ALIGNED ? it->statement_position()
+ : it->position());
+ it->Next();
+ }
+}
+
+void FindBreakablePositions(Handle<DebugInfo> debug_info, int start_position,
+ int end_position, BreakPositionAlignment alignment,
+ std::set<int>* positions) {
+ if (debug_info->HasDebugCode()) {
+ CodeBreakIterator it(debug_info, ALL_BREAK_LOCATIONS);
+ GetBreakablePositions(&it, start_position, end_position, alignment,
+ positions);
+ } else {
+ DCHECK(debug_info->HasDebugBytecodeArray());
+ BytecodeArrayBreakIterator it(debug_info, ALL_BREAK_LOCATIONS);
+ GetBreakablePositions(&it, start_position, end_position, alignment,
+ positions);
+ }
+}
+} // namespace
+
+bool Debug::GetPossibleBreakpoints(Handle<Script> script, int start_position,
+ int end_position, std::set<int>* positions) {
+ while (true) {
+ if (!script->shared_function_infos()->IsWeakFixedArray()) return false;
+
+ WeakFixedArray* infos =
+ WeakFixedArray::cast(script->shared_function_infos());
+ HandleScope scope(isolate_);
+ List<Handle<SharedFunctionInfo>> candidates;
+ {
+ WeakFixedArray::Iterator iterator(infos);
+ SharedFunctionInfo* info;
+ while ((info = iterator.Next<SharedFunctionInfo>())) {
+ if (info->end_position() < start_position ||
+ info->start_position() >= end_position) {
+ continue;
+ }
+ if (!info->IsSubjectToDebugging()) continue;
+ if (!info->HasDebugCode() && !info->allows_lazy_compilation()) continue;
+ candidates.Add(i::handle(info));
+ }
+ }
+
+ bool was_compiled = false;
+ for (int i = 0; i < candidates.length(); ++i) {
+ if (!candidates[i]->HasDebugCode()) {
+ if (!Compiler::CompileDebugCode(candidates[i])) {
+ return false;
+ } else {
+ was_compiled = true;
+ }
+ }
+ if (!candidates[i]->HasDebugInfo()) CreateDebugInfo(candidates[i]);
+ }
+ if (was_compiled) continue;
+
+ for (int i = 0; i < candidates.length(); ++i) {
+ CHECK(candidates[i]->HasDebugInfo());
+ Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo());
+ FindBreakablePositions(debug_info, start_position, end_position,
+ STATEMENT_ALIGNED, positions);
+ }
+ return true;
+ }
+ UNREACHABLE();
+ return false;
+}
+
void Debug::RecordAsyncFunction(Handle<JSGeneratorObject> generator_object) {
if (last_step_action() <= StepOut) return;
if (!IsAsyncFunction(generator_object->function()->shared()->kind())) return;
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug-interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698