Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 246403013: Revert of Revert of Extract most of the mutable state of SkShader into a separate Context object. (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/249643002/) Reason for revert: Chromium side change landed along side DEPS roll that includes r14323. Original issue's description: > Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/) > > Reason for revert: > This is blocking the DEPS roll into Chromium. Failures can be seen here: > > http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/174333 > > Original issue's description: > > Extract most of the mutable state of SkShader into a separate Context object. > > > > SkShader currently stores some state during draw calls via setContext(...). > > Move that mutable state into a separate SkShader::Context class that is > > constructed on demand for the duration of the draw. > > > > Calls to setContext() are replaced with createContext() which returns a context > > corresponding to the shader object or NULL if the parameters to createContext > > are invalid. > > > > TEST=out/Debug/dm > > BUG=skia:1976 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14216 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14323 > > TBR=scroggo@google.com,skyostil@chromium.org,tomhudson@chromium.org,senorblanco@chromium.org,reed@google.com,bungeman@google.com,dominikg@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia:1976 > > Committed: http://code.google.com/p/skia/source/detail?r=14326 TBR=scroggo@google.com,skyostil@chromium.org,tomhudson@chromium.org,senorblanco@chromium.org,reed@google.com,bungeman@google.com,dominikg@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:1976 Committed: http://code.google.com/p/skia/source/detail?r=14328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1759 lines, -1109 lines) Patch
M include/core/SkColorShader.h View 2 chunks +28 lines, -13 lines 0 comments Download
M include/core/SkComposeShader.h View 2 chunks +32 lines, -5 lines 0 comments Download
M include/core/SkEmptyShader.h View 1 chunk +17 lines, -9 lines 0 comments Download
M include/core/SkShader.h View 5 chunks +105 lines, -90 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 3 chunks +26 lines, -14 lines 0 comments Download
M include/effects/SkTransparentShader.h View 1 chunk +20 lines, -10 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 2 chunks +47 lines, -13 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 11 chunks +84 lines, -42 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 4 chunks +3 lines, -11 lines 0 comments Download
M src/core/SkBlitter.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkBlitter.cpp View 9 chunks +197 lines, -114 lines 0 comments Download
M src/core/SkBlitter_A8.cpp View 5 chunks +17 lines, -14 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 23 chunks +39 lines, -37 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 20 chunks +59 lines, -50 lines 0 comments Download
M src/core/SkCanvas.cpp View 13 chunks +3 lines, -49 lines 0 comments Download
M src/core/SkComposeShader.cpp View 5 chunks +65 lines, -38 lines 0 comments Download
M src/core/SkCoreBlitters.h View 4 chunks +25 lines, -5 lines 0 comments Download
M src/core/SkDraw.cpp View 8 chunks +69 lines, -36 lines 0 comments Download
M src/core/SkFilterShader.h View 1 chunk +23 lines, -6 lines 0 comments Download
M src/core/SkFilterShader.cpp View 2 chunks +53 lines, -27 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +33 lines, -8 lines 0 comments Download
M src/core/SkPictureShader.cpp View 4 chunks +96 lines, -68 lines 0 comments Download
M src/core/SkShader.cpp View 11 chunks +76 lines, -86 lines 0 comments Download
M src/core/SkSmallAllocator.h View 2 chunks +20 lines, -3 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 11 chunks +44 lines, -25 lines 0 comments Download
M src/effects/SkTransparentShader.cpp View 4 chunks +29 lines, -13 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 11 chunks +152 lines, -143 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 5 chunks +64 lines, -21 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +17 lines, -3 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 6 chunks +36 lines, -21 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +18 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 4 chunks +36 lines, -14 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 2 chunks +19 lines, -3 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 3 chunks +24 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 3 chunks +20 lines, -12 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 7 chunks +74 lines, -47 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 3 chunks +22 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 3 chunks +60 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Revert of Extract most of the mutable state of SkShader into a ...
6 years, 8 months ago (2014-04-23 19:09:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/246403013/1
6 years, 8 months ago (2014-04-23 19:09:36 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 19:11:35 UTC) #3
Message was sent while issue was closed.
Change committed as 14328

Powered by Google App Engine
This is Rietveld 408576698