Record permission prompt gesture metrics on Android.

Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599
Committed: https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c
Cr-Commit-Position: refs/heads/master@{#431384}

[dominickn, 2016-11-02 06:15:56]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 06:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-11-02 06:16:19]

Description was changed from

==========
Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599
==========

to

==========
Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599
==========

[dominickn, 2016-11-02 06:16:19]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2016-11-02 06:19:31]

PTAL, thanks!

[benwells, 2016-11-02 06:39:35]

https://codereview.chromium.org/2463393003/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_uma_util.h (right):

https://codereview.chromium.org/2463393003/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_uma_util.h:133: static void
RecordPermissionPromptTypeAndGesture(
Are you planning to add analogs for PermissionPromptAccepted? These are subtly
different to the other PermissionAccepted UMA.

[commit-bot: I haz the power, 2016-11-02 07:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 07:28:36]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-03 02:18:15]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-11-03 02:18:21]

Sadness.

https://codereview.chromium.org/2463393003/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_uma_util.h (right):

https://codereview.chromium.org/2463393003/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_uma_util.h:133: static void
RecordPermissionPromptTypeAndGesture(
On 2016/11/02 06:39:35, benwells (slow) wrote:
> Are you planning to add analogs for PermissionPromptAccepted? These are subtly
> different to the other PermissionAccepted UMA.

Oh crud, they're recorded separately too. This is horrible. :(

[commit-bot: I haz the power, 2016-11-03 02:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 03:14:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 03:14:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dominickn, 2016-11-09 03:16:25]

Ping.

[benwells, 2016-11-09 03:38:42]

On 2016/11/09 03:16:25, dominickn wrote:
> Ping.

Oh, sorry. Next time say 'Done' so it's clear you've uploaded another patch :)

[dominickn, 2016-11-10 00:54:19]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 00:54:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 02:22:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominickn, 2016-11-10 02:52:52]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 02:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2016-11-10 03:24:28]

lgtm

https://codereview.chromium.org/2463393003/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2463393003/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_queue_controller.cc:81: return
PermissionRequestType::PERMISSION_PROTECTED_MEDIA_IDENTIFIER;
This switch already exists pretty much in permission_request_impl.cc. Could we
put it somewhere common and reuse it?

Edit - looks like you've already put it in PermissionUtil - can yo use that?

https://codereview.chromium.org/2463393003/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_queue_controller.cc:237: // TODO(miguelg):
move the permission persistence to
is this TODO still valid? Maybe it should move somewhere else - it seems kinda
out of place.

[commit-bot: I haz the power, 2016-11-10 03:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 03:31:46]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-10 03:42:05]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 03:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 04:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 04:23:44]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-10 04:27:06]

dominickn@chromium.org changed reviewers:
+ sergeyu@chromium.org

[dominickn, 2016-11-10 04:27:07]

Thanks!

+sergeyu: PTAL at webrtc, thanks.

https://codereview.chromium.org/2463393003/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2463393003/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_queue_controller.cc:81: return
PermissionRequestType::PERMISSION_PROTECTED_MEDIA_IDENTIFIER;
On 2016/11/10 03:24:28, benwells (slow) wrote:
> This switch already exists pretty much in permission_request_impl.cc. Could we
> put it somewhere common and reuse it?
> 
> Edit - looks like you've already put it in PermissionUtil - can yo use that?

Done.

https://codereview.chromium.org/2463393003/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_queue_controller.cc:237: // TODO(miguelg):
move the permission persistence to
On 2016/11/10 03:24:28, benwells (slow) wrote:
> is this TODO still valid? Maybe it should move somewhere else - it seems kinda
> out of place.

Moved down to the update content setting call.

[Sergey Ulanov, 2016-11-10 20:36:32]

lgtm

[dominickn, 2016-11-10 22:25:25]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-11-10 22:25:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2463393003/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-11-10 22:26:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:40:49]

Description was changed from

==========
Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599
==========

to

==========
Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599
==========

[commit-bot: I haz the power, 2016-11-10 22:40:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 23:10:28]

Description was changed from

==========
Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599
==========

to

==========
Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG=614599

Committed: https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c
Cr-Commit-Position: refs/heads/master@{#431384}
==========

[commit-bot: I haz the power, 2016-11-10 23:10:30]

Patchset 4 (id:??) landed as
https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c
Cr-Commit-Position: refs/heads/master@{#431384}