Implement modal permission prompts for media permissions on Android.

Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, which is disabled by default. The
intention is to test this new prompt to a small percentage of users to
determine its effectiveness in improving the overall permissions request
flow.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
Committed: https://crrev.com/c70672a6e41ed5fa46bee5df7f0bdc99cbbf0476
Cr-Commit-Position: refs/heads/master@{#431142}

[dominickn, 2016-11-01 06:39:58]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 06:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-11-01 06:41:08]

Description was changed from

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, and by default requires the permission
to be requested with a user gesture.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
per-permission MediaStreamInfoBarDelegate class and allows the Java-side
dialog UI to communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

to

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, and by default requires the permission
to be requested with a user gesture.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

[dominickn, 2016-11-01 06:41:08]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org, raymes@chromium.org, xhwang@chromium.org

[dominickn, 2016-11-01 06:54:47]

Description was changed from

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, and by default requires the permission
to be requested with a user gesture.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

to

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, which is disabled by default. The
intention is to test this new prompt to a small percentage of users to
determine its effectiveness in improving the overall permissions request
flow.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

[dominickn, 2016-11-01 06:55:05]

dfalcantara: PTAL at MediaTest.java

xhwang: PTAL at media/

raymes: PTAL at permissions

Thanks!

[commit-bot: I haz the power, 2016-11-01 07:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:51:15]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-11-02 08:09:04]

https://codereview.chromium.org/2462963002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
(right):

https://codereview.chromium.org/2462963002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:45:
"Mic count:", "initiate_getMicrophone()", 1, false, false, false, false);
All these bools arguments are a little confusing - in C++ we would typically
annotate them with the argument name though I'm not sure if there is an
equivalent thing for Java so I'll leave it up to the Java folks :)

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/media/we...
File chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
(right):

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/media/we...
chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc:196:
PermissionDialogDelegate::CreateMediaStreamDialog(web_contents,
Hmm - there seems to be some logic in MediaStreamInfoBarDelegateAndroid::Create
that may be important:

if (!infobar_service) {
    // Deny the request if there is no place to show the infobar, e.g. when
    // the request comes from a background extension page.
    controller->Cancelled();
    return false;
  }

We may need to keep this logic?

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_dialog_delegate.h (right):

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_dialog_delegate.h:51: // TODO: remove this
when media stream requests are eventually folded in with
nit: Please add yourself as the TODO(author). Having yourself in a TODO doesn't
mean that you have to be the one to fix it, it just means that your are the one
who knows something about it.

[xhwang, 2016-11-02 16:54:47]

xhwang@chromium.org changed reviewers:
+ sergeyu@chromium.org
- xhwang@chromium.org

[xhwang, 2016-11-02 16:54:47]

xhwang -> sergeyu who is the webrtc owner

[dominickn, 2016-11-03 00:34:09]

https://codereview.chromium.org/2462963002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
(right):

https://codereview.chromium.org/2462963002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:45:
"Mic count:", "initiate_getMicrophone()", 1, false, false, false, false);
On 2016/11/02 08:09:03, raymes wrote:
> All these bools arguments are a little confusing - in C++ we would typically
> annotate them with the argument name though I'm not sure if there is an
> equivalent thing for Java so I'll leave it up to the Java folks :)

Acknowledged.

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/media/we...
File chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
(right):

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/media/we...
chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc:196:
PermissionDialogDelegate::CreateMediaStreamDialog(web_contents,
On 2016/11/02 08:09:04, raymes wrote:
> Hmm - there seems to be some logic in
MediaStreamInfoBarDelegateAndroid::Create
> that may be important:
> 
> if (!infobar_service) {
>     // Deny the request if there is no place to show the infobar, e.g. when
>     // the request comes from a background extension page.
>     controller->Cancelled();
>     return false;
>   }
> 
> We may need to keep this logic?

I don't think it's possible for anything except a real tab to request this
permission on Android (e.g. there are no extensions).

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_dialog_delegate.h (right):

https://codereview.chromium.org/2462963002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_dialog_delegate.h:51: // TODO: remove this
when media stream requests are eventually folded in with
On 2016/11/02 08:09:04, raymes wrote:
> nit: Please add yourself as the TODO(author). Having yourself in a TODO
doesn't
> mean that you have to be the one to fix it, it just means that your are the
one
> who knows something about it.

Done.

[dominickn, 2016-11-03 00:34:50]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:35:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:24:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2016-11-03 02:55:53]

lgtm

[gone, 2016-11-07 18:22:57]

lgtm

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
(right):

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:79:
@MediumTest
Not sure if these Smoke and MediumTest notations matter anymore (they might even
be deprecated).

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:84:
"Camera count:", "initiate_getCamera()", 1, false, false, false, false);
Is this exactly the same as above, except for the small change in the
commandline flags?

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:192:
* Verify combined creates an InfoBar with a persistence toggle if that feature
is enabled.
/methinks all of these javadocs need another pass.

[dominickn, 2016-11-08 20:28:44]

Thanks!

sergeyu: ping, it's been a week with no reply here.

[Sergey Ulanov, 2016-11-09 23:50:34]

lgtm

[dominickn, 2016-11-10 00:35:15]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 00:35:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-11-10 00:45:52]

Thanks!

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
(right):

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:79:
@MediumTest
On 2016/11/07 18:22:57, dfalcantara (check my queue) wrote:
> Not sure if these Smoke and MediumTest notations matter anymore (they might
even
> be deprecated).

There's actually a check in the instrumentation test runner that you have at
least one of them.  ¯\_(ツ)_/¯

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:84:
"Camera count:", "initiate_getCamera()", 1, false, false, false, false);
On 2016/11/07 18:22:57, dfalcantara (check my queue) wrote:
> Is this exactly the same as above, except for the small change in the
> commandline flags?

Yes, it's testing that even when modals are enabled, triggering a permission
prompt with no gesture gives an infobar.

https://codereview.chromium.org/2462963002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java:192:
* Verify combined creates an InfoBar with a persistence toggle if that feature
is enabled.
On 2016/11/07 18:22:57, dfalcantara (check my queue) wrote:
> /methinks all of these javadocs need another pass.

Done.

[commit-bot: I haz the power, 2016-11-10 01:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 01:29:41]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-10 02:04:37]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-11-10 02:04:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, raymes@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2462963002/#ps60001
(title: "Nits")

[commit-bot: I haz the power, 2016-11-10 02:05:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:12:17]

Description was changed from

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, which is disabled by default. The
intention is to test this new prompt to a small percentage of users to
determine its effectiveness in improving the overall permissions request
flow.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

to

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, which is disabled by default. The
intention is to test this new prompt to a small percentage of users to
determine its effectiveness in improving the overall permissions request
flow.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

[commit-bot: I haz the power, 2016-11-10 02:12:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 02:16:39]

Description was changed from

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, which is disabled by default. The
intention is to test this new prompt to a small percentage of users to
determine its effectiveness in improving the overall permissions request
flow.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125
==========

to

==========
Implement modal permission prompts for media permissions on Android.

This CL adds support for camera and microphone permission requests on
Android using a modal dialog prompt. This is controlled by the
ModalPermissionPrompts feature, which is disabled by default. The
intention is to test this new prompt to a small percentage of users to
determine its effectiveness in improving the overall permissions request
flow.

This follows crrev.com/2446063002, which implements the modal dialog
for all other permissions on Android.

Currently, modal prompts use a PermissionDialogDelegate, which wraps the
PermissionInfoBarDelegate class and allows the Java-side dialog UI to
communicate with the native C++ permissions layer.

Upcoming refactoring work will eliminate the per-permission
InfoBarDelegate classes, and simply allow the generic
PermissionInfoBarDelegate class to wrap a PermissionPromptAndroid object
which will provide all permission-specific data. At that point,
PermissionDialogDelegate will also change to analogously wrap
PermissionPromptAndroid.

New Android media permissions UI tests are introduced to test the modal
dialogs under various configurations, including with and without the
optional persistence toggle.

BUG=658125

Committed: https://crrev.com/c70672a6e41ed5fa46bee5df7f0bdc99cbbf0476
Cr-Commit-Position: refs/heads/master@{#431142}
==========

[commit-bot: I haz the power, 2016-11-10 02:16:40]

Patchset 4 (id:??) landed as
https://crrev.com/c70672a6e41ed5fa46bee5df7f0bdc99cbbf0476
Cr-Commit-Position: refs/heads/master@{#431142}