Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3882)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2463393003: Record permission prompt gesture metrics on Android. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/permissions/permission_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index b4dae09ec9c4070f4c72ec96544f6e9af9855575..8fe88da3c408c67b29f975f3ffb4eece806f58b3 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -371,10 +371,7 @@ void PermissionUmaUtil::PermissionPromptShown(
permission_gesture_type = requests[0]->GetGestureType();
}
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptShown, permission_prompt_type);
- PERMISSION_BUBBLE_GESTURE_TYPE_UMA(
- kPermissionsPromptShownGesture, kPermissionsPromptShownNoGesture,
- permission_gesture_type, permission_prompt_type);
+ RecordPermissionPromptShown(permission_prompt_type, permission_gesture_type);
UMA_HISTOGRAM_ENUMERATION(
kPermissionsPromptRequestsPerPrompt,
@@ -417,17 +414,11 @@ void PermissionUmaUtil::PermissionPromptAccepted(
}
if (all_accepted) {
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptAccepted,
- permission_prompt_type);
- PERMISSION_BUBBLE_GESTURE_TYPE_UMA(
- kPermissionsPromptAcceptedGesture, kPermissionsPromptAcceptedNoGesture,
- permission_gesture_type, permission_prompt_type);
+ RecordPermissionPromptAccepted(permission_prompt_type,
+ permission_gesture_type);
} else {
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied,
- permission_prompt_type);
- PERMISSION_BUBBLE_GESTURE_TYPE_UMA(
- kPermissionsPromptDeniedGesture, kPermissionsPromptDeniedNoGesture,
- permission_gesture_type, permission_prompt_type);
+ RecordPermissionPromptDenied(permission_prompt_type,
+ permission_gesture_type);
}
}
@@ -436,11 +427,35 @@ void PermissionUmaUtil::PermissionPromptDenied(
DCHECK(!requests.empty());
DCHECK(requests.size() == 1);
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied,
- requests[0]->GetPermissionRequestType());
+ RecordPermissionPromptDenied(requests[0]->GetPermissionRequestType(),
+ requests[0]->GetGestureType());
+}
+
+void PermissionUmaUtil::RecordPermissionPromptShown(
+ PermissionRequestType request_type,
+ PermissionRequestGestureType gesture_type) {
+ PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptShown, request_type);
PERMISSION_BUBBLE_GESTURE_TYPE_UMA(
- kPermissionsPromptDeniedGesture, kPermissionsPromptDeniedNoGesture,
- requests[0]->GetGestureType(), requests[0]->GetPermissionRequestType());
+ kPermissionsPromptShownGesture, kPermissionsPromptShownNoGesture,
+ gesture_type, request_type);
+}
+
+void PermissionUmaUtil::RecordPermissionPromptAccepted(
+ PermissionRequestType request_type,
+ PermissionRequestGestureType gesture_type) {
+ PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptAccepted, request_type);
+ PERMISSION_BUBBLE_GESTURE_TYPE_UMA(kPermissionsPromptAcceptedGesture,
+ kPermissionsPromptAcceptedNoGesture,
+ gesture_type, request_type);
+}
+
+void PermissionUmaUtil::RecordPermissionPromptDenied(
+ PermissionRequestType request_type,
+ PermissionRequestGestureType gesture_type) {
+ PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied, request_type);
+ PERMISSION_BUBBLE_GESTURE_TYPE_UMA(kPermissionsPromptDeniedGesture,
+ kPermissionsPromptDeniedNoGesture,
+ gesture_type, request_type);
}
void PermissionUmaUtil::RecordPermissionPromptPriorCount(
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/permissions/permission_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698