Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6171)

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2463393003: Record permission prompt gesture metrics on Android. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.cc
diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc
index 7eb5373abe5d431f1df999f68caeb17c0748c730..0abc8aa1313f8759320be3c2762b904c99bd8f41 100644
--- a/chrome/browser/permissions/permission_request_impl.cc
+++ b/chrome/browser/permissions/permission_request_impl.cc
@@ -145,33 +145,12 @@ bool PermissionRequestImpl::ShouldShowPersistenceToggle() const {
PermissionRequestType PermissionRequestImpl::GetPermissionRequestType()
const {
- switch (permission_type_) {
- case content::PermissionType::GEOLOCATION:
- return PermissionRequestType::PERMISSION_GEOLOCATION;
-#if defined(ENABLE_NOTIFICATIONS)
- case content::PermissionType::NOTIFICATIONS:
- return PermissionRequestType::PERMISSION_NOTIFICATIONS;
-#endif
- case content::PermissionType::MIDI_SYSEX:
- return PermissionRequestType::PERMISSION_MIDI_SYSEX;
- case content::PermissionType::PUSH_MESSAGING:
- return PermissionRequestType::PERMISSION_PUSH_MESSAGING;
-#if defined(OS_CHROMEOS)
- case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER:
- return PermissionRequestType::PERMISSION_PROTECTED_MEDIA_IDENTIFIER;
-#endif
- case content::PermissionType::FLASH:
- return PermissionRequestType::PERMISSION_FLASH;
- default:
- NOTREACHED();
- return PermissionRequestType::UNKNOWN;
- }
+ return PermissionUtil::GetRequestType(permission_type_);
}
PermissionRequestGestureType PermissionRequestImpl::GetGestureType()
const {
- return has_gesture_ ? PermissionRequestGestureType::GESTURE
- : PermissionRequestGestureType::NO_GESTURE;
+ return PermissionUtil::GetGestureType(has_gesture_);
}
ContentSettingsType PermissionRequestImpl::GetContentSettingsType() const {
« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698