Record permission prompt gesture metrics on Android.

chrome/browser/permissions/permission_uma_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/macros.h"
+#include "chrome/browser/permissions/permission_request.h"
 #include "chrome/browser/permissions/permission_util.h"
 
 enum class PermissionRequestGestureType;
 class GURL;
 class PermissionRequest;
 class Profile;
 
 namespace content {
 enum class PermissionType;
 }  // namespace content
@@ skipping 97 matching lines @@
   // useful to have separate UMA to a few reasons:
   // - to account for, and get data on coalesced permission bubbles
   // - there are other types of permissions prompts (e.g. download limiting)
   //   which don't go through PermissionContext
   // - the above metrics don't always add up (e.g. sum of
   //   granted+denied+dismissed+ignored is not equal to requested), so it is
   //   unclear from those metrics alone how many prompts are seen by users.
   static void PermissionPromptShown(
       const std::vector<PermissionRequest*>& requests);
 
+  // Records the request type and gesture type for a shown prompt. Defined
+  // separately as Android must call this method explicitly until the
+  // PermissionRequestManager refactoring is completed.
+  static void RecordPermissionPromptTypeAndGesture(

[benwells, 2016/11/02 06:39:35]

Are you planning to add analogs for PermissionPromptAccepted? These are subtly
different to the other PermissionAccepted UMA.

[dominickn, 2016/11/03 02:18:21]

Oh crud, they're recorded separately too. This is horrible. :(

+      PermissionRequestType request_type,
+      PermissionRequestGestureType gesture_type);
+
   // The following two functions can be combined with the PermissionPromptShown
   // metrics to calculate accept, deny and ignore rates.
   // Note that for coalesced permission bubbles, PermissionPromptAccepted will
   // always be called, with |accept_states| containing whether each request was
   // accepted or denied.
   static void PermissionPromptAccepted(
       const std::vector<PermissionRequest*>& requests,
       const std::vector<bool>& accept_states);
 
   static void PermissionPromptDenied(
@@ skipping 26 matching lines @@
   // for a single origin using |prefix| for the metric.
   static void RecordPermissionPromptPriorCount(
       content::PermissionType permission,
       const std::string& prefix,
       int count);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_