Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Issue 245963009: Use EXT_direct_state_access for path matrix manipulation (Closed)

Created:
6 years, 8 months ago by Kimmo Kinnunen
Modified:
6 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@nv-pr-00-no-ff-primitives
Visibility:
Public.

Description

Use EXT_direct_state_access for path matrix manipulation Use EXT_direct_state_access for path matrix manipulation when using NV_path_rendering extension. This makes Chromium command buffer integration easier, since the current matrix mode does not need to be exposed as state and fewer function calls and enums are needed. BUG=chromium:344330 Committed: http://code.google.com/p/skia/source/detail?r=14374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -53 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 chunks +3 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kimmo Kinnunen
Depends on: https://codereview.chromium.org/212753002
6 years, 8 months ago (2014-04-23 12:42:39 UTC) #1
bsalomon
lgtm
6 years, 8 months ago (2014-04-23 15:08:26 UTC) #2
Kimmo Kinnunen
The CQ bit was checked by kkinnunen@nvidia.com
6 years, 8 months ago (2014-04-25 05:47:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/245963009/1
6 years, 8 months ago (2014-04-25 05:48:18 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 06:21:42 UTC) #5
Message was sent while issue was closed.
Change committed as 14374

Powered by Google App Engine
This is Rietveld 408576698