Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: src/gpu/gl/GrGLInterface.cpp

Issue 245963009: Use EXT_direct_state_access for path matrix manipulation (Closed) Base URL: https://skia.googlesource.com/skia.git@nv-pr-00-no-ff-primitives
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/gl/GrGLCreateNullInterface.cpp ('k') | src/gpu/gl/GrGLNoOpInterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLInterface.cpp
diff --git a/src/gpu/gl/GrGLInterface.cpp b/src/gpu/gl/GrGLInterface.cpp
index 8aaa02e86b2eff2028048dcc2712298791a17eb5..b5da4d3a95982a09c6348d999ca5d419a209b299 100644
--- a/src/gpu/gl/GrGLInterface.cpp
+++ b/src/gpu/gl/GrGLInterface.cpp
@@ -228,13 +228,6 @@ bool GrGLInterface::validate() const {
GrGLVersion glVer = GrGLGetVersion(this);
- bool isCoreProfile = false;
- if (kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,2)) {
- GrGLint profileMask;
- GR_GL_GetIntegerv(this, GR_GL_CONTEXT_PROFILE_MASK, &profileMask);
- isCoreProfile = SkToBool(profileMask & GR_GL_CONTEXT_CORE_PROFILE_BIT);
- }
-
// Now check that baseline ES/Desktop fns not covered above are present
// and that we have fn pointers for any advertised fExtensions that we will
// try to use.
@@ -290,10 +283,9 @@ bool GrGLInterface::validate() const {
RETURN_FALSE_INTERFACE
}
}
- if (!isCoreProfile) {
- if (NULL == fFunctions.fLoadIdentity ||
- NULL == fFunctions.fLoadMatrixf ||
- NULL == fFunctions.fMatrixMode) {
+ if (fExtensions.has("GL_EXT_direct_state_access")) {
+ if (NULL == fFunctions.fMatrixLoadf ||
+ NULL == fFunctions.fMatrixLoadIdentity) {
RETURN_FALSE_INTERFACE
}
}
« no previous file with comments | « src/gpu/gl/GrGLCreateNullInterface.cpp ('k') | src/gpu/gl/GrGLNoOpInterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698