Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2459393003: Only promote fixed position elements on low dpi without transform or opacity. (Closed)

Created:
4 years, 1 month ago by flackr
Modified:
4 years, 1 month ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only promote fixed position elements on low dpi without transform or opacity. If the element has a transform or opacity it may lose LCD text if promoted. TEST=CompositingReasonFinderTest.OnlyNonTransformedFixedLayersPromoted, CompositingReasonFinderTest.OnlyOpaqueFixedLayersPromoted BUG=626200 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841 Cr-Commit-Position: refs/heads/master@{#429143}

Patch Set 1 #

Patch Set 2 : Remove unnecessary compositing setting. #

Total comments: 1

Patch Set 3 : Reset tests which are no longer composited to old expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -45 lines) Patch
D third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp View 1 1 chunk +162 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
flackr
PTAL, thanks! https://codereview.chromium.org/2459393003/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp File third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp (right): https://codereview.chromium.org/2459393003/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp#newcode29 third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp:29: TEST_F(CompositingReasonFinderTest, PromoteOpaqueFixedPosition) { This test is moved ...
4 years, 1 month ago (2016-10-31 17:38:38 UTC) #3
Stephen Chennney
LGTM. Thanks for adding the test. Moving forward I'll see what else we can do ...
4 years, 1 month ago (2016-10-31 19:12:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459393003/20001
4 years, 1 month ago (2016-10-31 19:15:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/322381)
4 years, 1 month ago (2016-10-31 20:46:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459393003/40001
4 years, 1 month ago (2016-11-01 18:30:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 22:51:58 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 22:54:54 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841
Cr-Commit-Position: refs/heads/master@{#429143}

Powered by Google App Engine
This is Rietveld 408576698