Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Issue 2459393003: Only promote fixed position elements on low dpi without transform or opacity. (Closed)
Patch Set: Reset tests which are no longer composited to old expectations. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
index f903b430f7e15d17007f653dd964302612b1b00c..22b69f679c0e5f21ec526f9ac6e97a7168158c83 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
@@ -791,47 +791,6 @@ TEST_P(CompositedLayerMappingTest, InterestRectOfIframeWithContentBoxOffset) {
->graphicsLayerBackingForScrolling()));
}
-TEST_P(CompositedLayerMappingTest, PromoteOpaqueFixedPosition) {
- const bool preferCompositing =
- document().frame()->settings()->preferCompositingToLCDTextEnabled();
- document().frame()->settings()->setPreferCompositingToLCDTextEnabled(false);
- ScopedCompositeFixedPositionForTest compositeFixedPosition(true);
-
- setBodyInnerHTML(
- "<div id='translucent' style='width: 20px; height: 20px; position: "
- "fixed; top: 100px; left: 100px;'></div>"
- "<div id='opaque' style='width: 20px; height: 20px; position: fixed; "
- "top: 100px; left: 200px; background: white;'></div>"
- "<div id='opaque-with-shadow' style='width: 20px; height: 20px; "
- "position: fixed; top: 100px; left: 300px; background: white; "
- "box-shadow: 10px 10px 5px #888888;'></div>"
- "<div id='spacer' style='height: 2000px'></div>");
-
- document().view()->updateAllLifecyclePhases();
-
- // The translucent fixed box should not be promoted.
- Element* element = document().getElementById("translucent");
- PaintLayer* paintLayer =
- toLayoutBoxModelObject(element->layoutObject())->layer();
- EXPECT_EQ(NotComposited, paintLayer->compositingState());
-
- // The opaque fixed box should be promoted and be opaque so that text will be
- // drawn with subpixel anti-aliasing.
- element = document().getElementById("opaque");
- paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();
- EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
- EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
-
- // The opaque fixed box with shadow should not be promoted because the layer
- // will include the shadow which is not opaque.
- element = document().getElementById("opaque-with-shadow");
- paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();
- EXPECT_EQ(NotComposited, paintLayer->compositingState());
-
- document().frame()->settings()->setPreferCompositingToLCDTextEnabled(
- preferCompositing);
-}
-
TEST_P(CompositedLayerMappingTest,
ScrollingContentsAndForegroundLayerPaintingPhase) {
document().frame()->settings()->setPreferCompositingToLCDTextEnabled(true);
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698