Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2459393003: Only promote fixed position elements on low dpi without transform or opacity. (Closed)
Patch Set: Reset tests which are no longer composited to old expectations. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1678 CompositorMutableProperty::kScrollLeft))) 1678 CompositorMutableProperty::kScrollLeft)))
1679 return true; 1679 return true;
1680 1680
1681 // TODO(flackr): Allow integer transforms as long as all of the ancestor 1681 // TODO(flackr): Allow integer transforms as long as all of the ancestor
1682 // transforms are also integer. 1682 // transforms are also integer.
1683 bool backgroundSupportsLCDText = 1683 bool backgroundSupportsLCDText =
1684 RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled() && 1684 RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled() &&
1685 layer->canPaintBackgroundOntoScrollingContentsLayer() && 1685 layer->canPaintBackgroundOntoScrollingContentsLayer() &&
1686 layer->backgroundIsKnownToBeOpaqueInRect( 1686 layer->backgroundIsKnownToBeOpaqueInRect(
1687 toLayoutBox(layer->layoutObject())->paddingBoxRect()) && 1687 toLayoutBox(layer->layoutObject())->paddingBoxRect()) &&
1688 !layer->transformAncestor() && !layer->transform() && 1688 !layer->compositesWithTransform() && !layer->compositesWithOpacity();
1689 !layer->opacityAncestor() &&
1690 !layer->layoutObject()->style()->hasOpacity();
1691 if (mode == PaintLayerScrollableArea::ConsiderLCDText && 1689 if (mode == PaintLayerScrollableArea::ConsiderLCDText &&
1692 !layer->compositor()->preferCompositingToLCDTextEnabled() && 1690 !layer->compositor()->preferCompositingToLCDTextEnabled() &&
1693 !backgroundSupportsLCDText) 1691 !backgroundSupportsLCDText)
1694 return false; 1692 return false;
1695 1693
1696 // TODO(schenney) Tests fail if we do not also exclude 1694 // TODO(schenney) Tests fail if we do not also exclude
1697 // layer->layoutObject()->style()->hasBorderDecoration() (missing background 1695 // layer->layoutObject()->style()->hasBorderDecoration() (missing background
1698 // behind dashed borders). Resolve this case, or not, and update this check 1696 // behind dashed borders). Resolve this case, or not, and update this check
1699 // with the results. 1697 // with the results.
1700 return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() || 1698 return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() ||
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
1961 1959
1962 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 1960 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
1963 clampScrollableAreas() { 1961 clampScrollableAreas() {
1964 for (auto& scrollableArea : *s_needsClamp) 1962 for (auto& scrollableArea : *s_needsClamp)
1965 scrollableArea->clampScrollOffsetsAfterLayout(); 1963 scrollableArea->clampScrollOffsetsAfterLayout();
1966 delete s_needsClamp; 1964 delete s_needsClamp;
1967 s_needsClamp = nullptr; 1965 s_needsClamp = nullptr;
1968 } 1966 }
1969 1967
1970 } // namespace blink 1968 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698