third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 2459393003: Only promote fixed position elements on low dpi without transform or opacity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2459393003: Only promote fixed position elements on low dpi without transform or opacity. (Closed)

Patch Set: Reset tests which are no longer composited to old expectations. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index e702b1b52e050cc6127aaf1821ba983101cb3061..79777cffaf1d34fb2e44eedef1cd7a4609032a25 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -187,7 +187,8 @@ bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(

if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) &&

(!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() ||

!layer->backgroundIsKnownToBeOpaqueInRect(

- LayoutRect(layer->boundingBoxForCompositing())))) {

+ LayoutRect(layer->boundingBoxForCompositing())) ||

+ layer->compositesWithTransform() || layer->compositesWithOpacity())) {

return false;

}

// Don't promote fixed position elements that are descendants of a non-view