Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2459393003: Only promote fixed position elements on low dpi without transform or opacity. (Closed)
Patch Set: Reset tests which are no longer composited to old expectations. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/compositing/CompositingReasonFinder.h" 5 #include "core/layout/compositing/CompositingReasonFinder.h"
6 6
7 #include "core/CSSPropertyNames.h" 7 #include "core/CSSPropertyNames.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/FrameView.h" 9 #include "core/frame/FrameView.h"
10 #include "core/frame/Settings.h" 10 #include "core/frame/Settings.h"
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 180
181 bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition( 181 bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(
182 const PaintLayer* layer) const { 182 const PaintLayer* layer) const {
183 if (layer->layoutObject()->style()->position() != FixedPosition && 183 if (layer->layoutObject()->style()->position() != FixedPosition &&
184 layer->layoutObject()->style()->position() != StickyPosition) 184 layer->layoutObject()->style()->position() != StickyPosition)
185 return false; 185 return false;
186 186
187 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) && 187 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) &&
188 (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() || 188 (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() ||
189 !layer->backgroundIsKnownToBeOpaqueInRect( 189 !layer->backgroundIsKnownToBeOpaqueInRect(
190 LayoutRect(layer->boundingBoxForCompositing())))) { 190 LayoutRect(layer->boundingBoxForCompositing())) ||
191 layer->compositesWithTransform() || layer->compositesWithOpacity())) {
191 return false; 192 return false;
192 } 193 }
193 // Don't promote fixed position elements that are descendants of a non-view 194 // Don't promote fixed position elements that are descendants of a non-view
194 // container, e.g. transformed elements. They will stay fixed wrt the 195 // container, e.g. transformed elements. They will stay fixed wrt the
195 // container rather than the enclosing frame. 196 // container rather than the enclosing frame.
196 if (layer->scrollsWithViewport()) 197 if (layer->scrollsWithViewport())
197 return m_layoutView.frameView()->isScrollable(); 198 return m_layoutView.frameView()->isScrollable();
198 return layer->layoutObject()->style()->position() == StickyPosition && 199 return layer->layoutObject()->style()->position() == StickyPosition &&
199 layer->ancestorOverflowLayer()->scrollsOverflow(); 200 layer->ancestorOverflowLayer()->scrollsOverflow();
200 } 201 }
201 202
202 } // namespace blink 203 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698