|
|
Chromium Code Reviews
DescriptionReland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ )
Reason for revert:
Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string.
Original issue's description:
> Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ )
>
> Reason for revert:
> Looks like some reference builds still haven't got the devtools api update.
>
> Original issue's description:
> > [telemetry] Trace config should be used to disable periodic dumps
> >
> > Telemetry previously used the "--enable-memory-benchmarking" flag to
> > tell memory dump manager to disable periodic dumps. That is cleaned up
> > in this CL and the trace config is used to achieve this behavior.
> >
> > Note to perf sheriff: Memory benchmarks could regress if the config
> > did not propagate correctly.
> >
> > BUG=513692
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
> >
> > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6
> > Cr-Commit-Position: refs/heads/master@{#406598}
>
> TBR=nednguyen@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=629988, 513692
>
> Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26
> Cr-Commit-Position: refs/heads/master@{#406691}
TBR=nednguyen@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629988, 513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be
Cr-Commit-Position: refs/heads/master@{#432846}
Patch Set 1 : Original CL. #Patch Set 2 : rebase. #
Dependent Patchsets: Messages
Total messages: 47 (38 generated)
Created Reland of [telemetry] Trace config should be used to disable periodic dumps
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
Description was changed from ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 ========== to ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
landing this CL again so that we do not need enable-memory-benchmarking flag in memory-infra. This was reverted because the old reference builds did not support trace_config string via devtools Tracing.Start. Now, the reference build was rolled (crbug.com/29987).
Description was changed from ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
lgtm
On 2016/11/03 10:06:03, nednguyen wrote: > lgtm thanks so much!
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by ssid@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2458413002/#ps150001 (title: "Testing tot.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)
Patchset #3 (id:150001) has been deleted
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:130001)
Message was sent while issue was closed.
Description was changed from ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be Cr-Commit-Position: refs/heads/master@{#432846} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be Cr-Commit-Position: refs/heads/master@{#432846} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
