Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2458413002: Reland of [telemetry] Trace config should be used to disable periodic dumps (Closed)

Created:
4 years, 1 month ago by ssid
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, perezju
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987. Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG=513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629988, 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629988, 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be Cr-Commit-Position: refs/heads/master@{#432846}

Patch Set 1 : Original CL. #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/oortonline.py View 1 3 chunks +4 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/system_health.py View 1 2 chunks +4 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 1 3 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 47 (38 generated)
ssid
Created Reland of [telemetry] Trace config should be used to disable periodic dumps
4 years, 1 month ago (2016-10-31 04:32:18 UTC) #1
ssid
landing this CL again so that we do not need enable-memory-benchmarking flag in memory-infra. This ...
4 years, 1 month ago (2016-11-03 07:56:04 UTC) #9
nednguyen
lgtm
4 years, 1 month ago (2016-11-03 10:06:03 UTC) #13
Primiano Tucci (use gerrit)
On 2016/11/03 10:06:03, nednguyen wrote: > lgtm thanks so much!
4 years, 1 month ago (2016-11-03 13:33:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458413002/150001
4 years, 1 month ago (2016-11-16 12:10:10 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_cq/builds/635)
4 years, 1 month ago (2016-11-16 14:52:13 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458413002/130001
4 years, 1 month ago (2016-11-17 11:49:07 UTC) #43
commit-bot: I haz the power
Committed patchset #2 (id:130001)
4 years, 1 month ago (2016-11-17 11:53:05 UTC) #45
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 11:55:06 UTC) #47
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be
Cr-Commit-Position: refs/heads/master@{#432846}

Powered by Google App Engine
This is Rietveld 408576698