Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2458413002: Reland of [telemetry] Trace config should be used to disable periodic dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/oortonline.py ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index 6303fbbb7bc8be859fd3059ec518869d108d53db..35d838129282f8da2de22542654fc673e80bab4c 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -7,6 +7,7 @@ import re
from core import perf_benchmark
from telemetry import benchmark
from telemetry.timeline import chrome_trace_category_filter
+from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement
import page_sets
@@ -85,19 +86,15 @@ class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
"""
options = {'pageset_repeat': 3}
- def SetExtraBrowserOptions(self, options):
- options.AppendExtraBrowserArgs([
- # TODO(perezju): Temporary workaround to disable periodic memory dumps.
- # See: http://crbug.com/513692
- '--enable-memory-benchmarking',
- ])
-
def CreateTimelineBasedMeasurementOptions(self):
options = timeline_based_measurement.Options(
chrome_trace_category_filter.ChromeTraceCategoryFilter(
'-*,disabled-by-default-memory-infra'))
options.config.enable_android_graphics_memtrack = True
options.SetTimelineBasedMetrics(['memoryMetric'])
+ # Setting an empty memory dump config disables periodic dumps.
+ options.config.chrome_trace_config.SetMemoryDumpConfig(
+ chrome_trace_config.MemoryDumpConfig())
return options
def CreateStorySet(self, options):
« no previous file with comments | « tools/perf/benchmarks/oortonline.py ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698