Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: tools/perf/benchmarks/oortonline.py

Issue 2458413002: Reland of [telemetry] Trace config should be used to disable periodic dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | tools/perf/benchmarks/system_health.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/oortonline.py
diff --git a/tools/perf/benchmarks/oortonline.py b/tools/perf/benchmarks/oortonline.py
index cb88a55321085b58e866f3f83864d135558b60cd..810a1eb4db5a0533c9a87b9f48a8e00aa8717a6b 100644
--- a/tools/perf/benchmarks/oortonline.py
+++ b/tools/perf/benchmarks/oortonline.py
@@ -12,6 +12,7 @@ from telemetry.page import legacy_page_test
from telemetry.value import scalar
from telemetry.value import improvement_direction
from telemetry.timeline import chrome_trace_category_filter
+from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement
@@ -63,13 +64,6 @@ class OortOnlineTBMv2(perf_benchmark.PerfBenchmark):
page_set = page_sets.OortOnlineTBMPageSet
- def SetExtraBrowserOptions(self, options):
- options.AppendExtraBrowserArgs([
- # TODO(perezju): Temporary workaround to disable periodic memory dumps.
- # See: http://crbug.com/513692
- '--enable-memory-benchmarking',
- ])
-
def CreateTimelineBasedMeasurementOptions(self):
categories = [
# Implicitly disable all categories.
@@ -95,6 +89,9 @@ class OortOnlineTBMv2(perf_benchmark.PerfBenchmark):
options = timeline_based_measurement.Options(category_filter)
options.SetTimelineBasedMetrics([
'gcMetric', 'memoryMetric', 'responsivenessMetric'])
+ # Setting an empty memory dump config disables periodic dumps.
+ options.config.chrome_trace_config.SetMemoryDumpConfig(
+ chrome_trace_config.MemoryDumpConfig())
return options
@classmethod
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | tools/perf/benchmarks/system_health.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698