Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2468363003: Remove "enable-memory-benchmarking" flag (Closed)

Created:
4 years, 1 month ago by ssid
Modified:
4 years ago
CC:
chromium-reviews, creis+watch_chromium.org, wfh+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, tracing+reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "enable-memory-benchmarking" flag This flag was not used anywhere except memory-infra to disable periodic dumps as workaround. Now this use case no longer exists. BUG=513692 Committed: https://crrev.com/efcb350230f902db9d582da568c9790f7e36d6b0 Cr-Commit-Position: refs/heads/master@{#439631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (12 generated)
ssid
ptal just 3 lines cl. All the benchmarks now use trace config (including reference builds).
4 years ago (2016-12-16 21:47:07 UTC) #3
Primiano Tucci (use gerrit)
YESSSSSSSSS. We can finally get rid of this piece of awkwardness. Thanks a lot. __ ...
4 years ago (2016-12-19 21:10:04 UTC) #4
ssid
+jochen PTAl at content/ changes. Cl only deals with "switches" files.
4 years ago (2016-12-19 21:13:15 UTC) #6
Primiano Tucci (use gerrit)
Maybe let's pick some reviewer in your timezone? jochen -> pfeldman , so we also ...
4 years ago (2016-12-19 21:21:33 UTC) #8
pfeldman
lgtm
4 years ago (2016-12-19 22:30:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468363003/1
4 years ago (2016-12-20 00:15:12 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:21:17 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-20 00:22:55 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efcb350230f902db9d582da568c9790f7e36d6b0
Cr-Commit-Position: refs/heads/master@{#439631}

Powered by Google App Engine
This is Rietveld 408576698