Reland of [telemetry] Trace config should be used to disable periodic dumps

tools/perf/benchmarks/oortonline.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 import page_sets
 
 from core import perf_benchmark
 from telemetry import benchmark
 from telemetry.page import legacy_page_test
 from telemetry.value import scalar
 from telemetry.value import improvement_direction
 from telemetry.timeline import chrome_trace_category_filter
+from telemetry.timeline import chrome_trace_config
 from telemetry.web_perf import timeline_based_measurement
 
 
 class _OortOnlineMeasurement(legacy_page_test.LegacyPageTest):
 
   def __init__(self):
     super(_OortOnlineMeasurement, self).__init__()
 
   def ValidateAndMeasurePage(self, page, tab, results):
     del page  # unused
@@ skipping 31 matching lines @@
   """
 
   # Report only V8-specific and overall renderer memory values. Note that
   # detailed values reported by the OS (such as native heap) are excluded.
   _V8_AND_OVERALL_MEMORY_RE = re.compile(
       r'renderer_processes:'
       r'(reported_by_chrome:v8|reported_by_os:system_memory:[^:]+$)')
 
   page_set = page_sets.OortOnlineTBMPageSet
 
-  def SetExtraBrowserOptions(self, options):
-    options.AppendExtraBrowserArgs([
-        # TODO(perezju): Temporary workaround to disable periodic memory dumps.
-        # See: http://crbug.com/513692
-        '--enable-memory-benchmarking',
-    ])
-
   def CreateTimelineBasedMeasurementOptions(self):
     categories = [
       # Implicitly disable all categories.
       '-*',
       # V8.
       'blink.console',
       'disabled-by-default-v8.gc',
       'renderer.scheduler',
       'v8',
       'webkit.console',
       # Smoothness.
       'benchmark',
       'blink',
       'blink.console',
       'trace_event_overhead',
       'webkit.console',
       # Memory.
       'blink.console',
       'disabled-by-default-memory-infra'
     ]
     category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
         ','.join(categories))
     options = timeline_based_measurement.Options(category_filter)
     options.SetTimelineBasedMetrics([
         'gcMetric', 'memoryMetric', 'responsivenessMetric'])
+    # Setting an empty memory dump config disables periodic dumps.
+    options.config.chrome_trace_config.SetMemoryDumpConfig(
+        chrome_trace_config.MemoryDumpConfig())
     return options
 
   @classmethod
   def Name(cls):
     return 'oortonline_tbmv2'
 
   @classmethod
   def ValueCanBeAddedPredicate(cls, value, _):
     if 'memory:chrome' in value.name:
       return bool(cls._V8_AND_OVERALL_MEMORY_RE.search(value.name))
     if 'animation ' in value.name:
       return 'throughput' in value.name or 'frameTimeDiscrepancy' in value.name
     return 'v8' in value.name