Fix some FX_BOOL / int noise in fxfa

Fix some FX_BOOL / int noise in fxfa

Committed: https://pdfium.googlesource.com/pdfium/+/478ed62770e0dc0fe2d859e73496fa8c7f854694

[Tom Sepez, 2016-10-27 20:54:01]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:54:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-27 21:04:49]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-10-27 21:04:50]

Lei, for review.

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp
File xfa/fxfa/app/xfa_ffdocview.cpp (right):

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffdocview....
xfa/fxfa/app/xfa_ffdocview.cpp:539: return m_iLock > 0;
just in case we unlock it too many times.

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_fftextedit...
File xfa/fxfa/app/xfa_fftextedit.cpp (right):

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_fftextedit...
xfa/fxfa/app/xfa_fftextedit.cpp:328: return
((CFWL_Edit*)m_pNormalWidget)->AddSelRange(0, nCount) >= 0;
uses -1 as an error code at
https://cs.chromium.org/chromium/src/third_party/pdfium/xfa/fwl/core/cfwl_edi...

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffwidgetha...
File xfa/fxfa/app/xfa_ffwidgethandler.cpp (right):

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffwidgetha...
xfa/fxfa/app/xfa_ffwidgethandler.cpp:213: return
pWidgetAcc->GetEventByActivity(gs_EventActivity[eEventType],
Returns a count of events.  Probably should be unsigned.

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_textlayout...
File xfa/fxfa/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout.cpp:1279: return iPieceLines > 0;
another count

[commit-bot: I haz the power, 2016-10-27 21:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:07:20]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-27 21:28:53]

lgtm

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp
File xfa/fxfa/app/xfa_ffdocview.cpp (right):

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffdocview....
xfa/fxfa/app/xfa_ffdocview.cpp:539: return m_iLock > 0;
On 2016/10/27 21:04:49, Tom Sepez wrote:
> just in case we unlock it too many times.

Maybe UnlockUpdate() should ASSERT...

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffwidgetha...
File xfa/fxfa/app/xfa_ffwidgethandler.cpp (right):

https://codereview.chromium.org/2457673003/diff/1/xfa/fxfa/app/xfa_ffwidgetha...
xfa/fxfa/app/xfa_ffwidgethandler.cpp:213: return
pWidgetAcc->GetEventByActivity(gs_EventActivity[eEventType],
On 2016/10/27 21:04:49, Tom Sepez wrote:
> Returns a count of events.  Probably should be unsigned.

Yes, many many things need to be unsigned...

[Tom Sepez, 2016-10-27 21:32:14]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:32:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:32:35]

Description was changed from

==========
Fix some FX_BOOL / int noise in fxfa
==========

to

==========
Fix some FX_BOOL / int noise in fxfa

Committed:
https://pdfium.googlesource.com/pdfium/+/478ed62770e0dc0fe2d859e73496fa8c7f85...
==========

[commit-bot: I haz the power, 2016-10-27 21:32:36]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/478ed62770e0dc0fe2d859e73496fa8c7f85...