Fix some FX_BOOL / int noise in fxfa

xfa/fxfa/app/xfa_ffdocview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/xfa_ffdocview.h"
 
 #include "core/fxcrt/fx_ext.h"
 #include "xfa/fxfa/app/xfa_ffbarcode.h"
@@ skipping 518 matching lines @@
   m_pDoc->GetDocEnvironment()->PageViewEvent(pFFPageView, dwEvent);
 }
 
 void CXFA_FFDocView::LockUpdate() {
   m_iLock++;
 }
 void CXFA_FFDocView::UnlockUpdate() {
   m_iLock--;
 }
 FX_BOOL CXFA_FFDocView::IsUpdateLocked() {
-  return m_iLock;
+  return m_iLock > 0;

[Tom Sepez, 2016/10/27 21:04:49]

just in case we unlock it too many times.

[Lei Zhang, 2016/10/27 21:28:52]

Maybe UnlockUpdate() should ASSERT...

 }
 void CXFA_FFDocView::ClearInvalidateList() {
   m_mapPageInvalidate.clear();
 }
 void CXFA_FFDocView::AddInvalidateRect(CXFA_FFWidget* pWidget,
                                        const CFX_RectF& rtInvalidate) {
   AddInvalidateRect(pWidget->GetPageView(), rtInvalidate);
 }
 
 void CXFA_FFDocView::AddInvalidateRect(CXFA_FFPageView* pPageView,
@@ skipping 300 matching lines @@
 }
 
 FX_BOOL CXFA_WidgetAccIterator::SetCurrentWidgetAcc(CXFA_WidgetAcc* hWidget) {
   return FALSE;
 }
 
 void CXFA_WidgetAccIterator::SkipTree() {
   m_ContentIterator.SkipChildrenAndMoveToNext();
   m_pCurWidgetAcc = nullptr;
 }