Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

Issue 2457673003: Fix some FX_BOOL / int noise in fxfa (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h" 7 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
8 8
9 #include <time.h> 9 #include <time.h>
10 10
(...skipping 4635 matching lines...) Expand 10 before | Expand all | Expand 10 after
4646 4646
4647 int32_t iNum = 0; 4647 int32_t iNum = 0;
4648 if (argc > 0) { 4648 if (argc > 0) {
4649 std::unique_ptr<CFXJSE_Value> argOne = GetSimpleValue(pThis, args, 0); 4649 std::unique_ptr<CFXJSE_Value> argOne = GetSimpleValue(pThis, args, 0);
4650 iNum = static_cast<int32_t>(ValueToFloat(pThis, argOne.get())); 4650 iNum = static_cast<int32_t>(ValueToFloat(pThis, argOne.get()));
4651 } 4651 }
4652 FX_GUID guid; 4652 FX_GUID guid;
4653 FX_GUID_CreateV4(&guid); 4653 FX_GUID_CreateV4(&guid);
4654 4654
4655 CFX_ByteString bsUId; 4655 CFX_ByteString bsUId;
4656 FX_GUID_ToString(&guid, bsUId, iNum); 4656 FX_GUID_ToString(&guid, bsUId, !!iNum);
4657 args.GetReturnValue()->SetString(bsUId.AsStringC()); 4657 args.GetReturnValue()->SetString(bsUId.AsStringC());
4658 } 4658 }
4659 4659
4660 // static 4660 // static
4661 void CXFA_FM2JSContext::Upper(CFXJSE_Value* pThis, 4661 void CXFA_FM2JSContext::Upper(CFXJSE_Value* pThis,
4662 const CFX_ByteStringC& szFuncName, 4662 const CFX_ByteStringC& szFuncName,
4663 CFXJSE_Arguments& args) { 4663 CFXJSE_Arguments& args) {
4664 int32_t argc = args.GetLength(); 4664 int32_t argc = args.GetLength();
4665 if (argc < 1 || argc > 2) { 4665 if (argc < 1 || argc > 2) {
4666 ToJSContext(pThis, nullptr) 4666 ToJSContext(pThis, nullptr)
(...skipping 1851 matching lines...) Expand 10 before | Expand all | Expand 10 after
6518 CFX_WideString wsFormat; 6518 CFX_WideString wsFormat;
6519 pAppProvider->LoadString(iStringID, wsFormat); 6519 pAppProvider->LoadString(iStringID, wsFormat);
6520 CFX_WideString wsMessage; 6520 CFX_WideString wsMessage;
6521 va_list arg_ptr; 6521 va_list arg_ptr;
6522 va_start(arg_ptr, iStringID); 6522 va_start(arg_ptr, iStringID);
6523 wsMessage.FormatV(wsFormat.c_str(), arg_ptr); 6523 wsMessage.FormatV(wsFormat.c_str(), arg_ptr);
6524 va_end(arg_ptr); 6524 va_end(arg_ptr);
6525 FXJSE_ThrowMessage( 6525 FXJSE_ThrowMessage(
6526 FX_UTF8Encode(wsMessage.c_str(), wsMessage.GetLength()).AsStringC()); 6526 FX_UTF8Encode(wsMessage.c_str(), wsMessage.GetLength()).AsStringC());
6527 } 6527 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698