Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxfa/app/xfa_ffdocview.cpp

Issue 2457673003: Fix some FX_BOOL / int noise in fxfa (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fxfa/app/xfa_fftextedit.cpp » ('j') | xfa/fxfa/app/xfa_fftextedit.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/app/xfa_ffdocview.cpp
diff --git a/xfa/fxfa/app/xfa_ffdocview.cpp b/xfa/fxfa/app/xfa_ffdocview.cpp
index efda0430d3bba06a2f2a9079c60f356ead117964..f82cc5eafb8e9ad19fc6674b303fc11c66846296 100644
--- a/xfa/fxfa/app/xfa_ffdocview.cpp
+++ b/xfa/fxfa/app/xfa_ffdocview.cpp
@@ -536,7 +536,7 @@ void CXFA_FFDocView::UnlockUpdate() {
m_iLock--;
}
FX_BOOL CXFA_FFDocView::IsUpdateLocked() {
- return m_iLock;
+ return m_iLock > 0;
Tom Sepez 2016/10/27 21:04:49 just in case we unlock it too many times.
Lei Zhang 2016/10/27 21:28:52 Maybe UnlockUpdate() should ASSERT...
}
void CXFA_FFDocView::ClearInvalidateList() {
m_mapPageInvalidate.clear();
« no previous file with comments | « no previous file | xfa/fxfa/app/xfa_fftextedit.cpp » ('j') | xfa/fxfa/app/xfa_fftextedit.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698