Fix some FX_BOOL / int noise in fxfa

xfa/fxfa/app/xfa_fftextedit.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/app/xfa_fftextedit.h"
 
 #include <vector>
 
@@ skipping 307 matching lines @@
   return ((CFWL_Edit*)m_pNormalWidget)->Copy(wsCopy);
 }
 FX_BOOL CXFA_FFTextEdit::Cut(CFX_WideString& wsCut) {
   return ((CFWL_Edit*)m_pNormalWidget)->Cut(wsCut);
 }
 FX_BOOL CXFA_FFTextEdit::Paste(const CFX_WideString& wsPaste) {
   return ((CFWL_Edit*)m_pNormalWidget)->Paste(wsPaste);
 }
 FX_BOOL CXFA_FFTextEdit::SelectAll() {
   int32_t nCount = ((CFWL_Edit*)m_pNormalWidget)->GetTextLength();
-  return ((CFWL_Edit*)m_pNormalWidget)->AddSelRange(0, nCount);
+  return ((CFWL_Edit*)m_pNormalWidget)->AddSelRange(0, nCount) >= 0;

[Tom Sepez, 2016/10/27 21:04:49]

uses -1 as an error code at
https://cs.chromium.org/chromium/src/third_party/pdfium/xfa/fwl/core/cfwl_edi...

 }
 FX_BOOL CXFA_FFTextEdit::Delete() {
   return ((CFWL_Edit*)m_pNormalWidget)->Delete();
 }
 FX_BOOL CXFA_FFTextEdit::DeSelect() {
   return ((CFWL_Edit*)m_pNormalWidget)->ClearSelections() ==
          FWL_Error::Succeeded;
 }
 FX_BOOL CXFA_FFTextEdit::GetSuggestWords(
     CFX_PointF pointf,
@@ skipping 443 matching lines @@
 
 void CXFA_FFDateTimeEdit::OnProcessEvent(CFWL_Event* pEvent) {
   if (pEvent->GetClassID() == CFWL_EventType::SelectChanged) {
     CFWL_Event_DtpSelectChanged* event = (CFWL_Event_DtpSelectChanged*)pEvent;
     OnSelectChanged(m_pNormalWidget->GetWidget(), event->iYear, event->iMonth,
                     event->iDay);
     return;
   }
   CXFA_FFTextEdit::OnProcessEvent(pEvent);
 }