Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2456773002: Clear the custom element's reaction queue if upgrade fails. (Closed)

Created:
4 years, 1 month ago by dominicc (has gone to gerrit)
Modified:
4 years, 1 month ago
Reviewers:
domenic, hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the custom element's reaction queue if upgrade fails. This is step 7."Finally, ...".2 of <https://html.spec.whatwg.org/#concept-upgrade-an-element>; BUG=645335 Committed: https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5 Cr-Commit-Position: refs/heads/master@{#428288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html View 2 chunks +3 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.h View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 3 chunks +18 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h View 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 1 month ago (2016-10-27 06:07:53 UTC) #4
domenic
lgtm
4 years, 1 month ago (2016-10-27 20:07:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456773002/1
4 years, 1 month ago (2016-10-28 03:41:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 05:04:27 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 05:06:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5
Cr-Commit-Position: refs/heads/master@{#428288}

Powered by Google App Engine
This is Rietveld 408576698