third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp - Issue 2456773002: Clear the custom element's reaction queue if upgrade fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2456773002: Clear the custom element's reaction queue if upgrade fails. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

index e18186119e3571c5895c4181fdf87599be624124..2d3925b55523cc2d7d6e357b1fd10764117b31bc 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

@@ -12,6 +12,7 @@

#include "core/dom/custom/CustomElementConnectedCallbackReaction.h"

#include "core/dom/custom/CustomElementDisconnectedCallbackReaction.h"

#include "core/dom/custom/CustomElementReaction.h"

+#include "core/dom/custom/CustomElementReactionStack.h"

#include "core/dom/custom/CustomElementUpgradeReaction.h"

#include "core/html/HTMLElement.h"

@@ -154,6 +155,7 @@ void CustomElementDefinition::upgrade(Element* element) {

}

if (!succeeded) {

element->setCustomElementState(CustomElementState::Failed);

+ CustomElementReactionStack::current().clearQueue(element);

return;

}