Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp

Issue 2456773002: Clear the custom element's reaction queue if upgrade fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..9cf7855e4ac67a9bd6a54d50e1cf68221699848b
--- /dev/null
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp
@@ -0,0 +1,61 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/dom/custom/CustomElementDefinition.h"
+
+#include "core/dom/Node.h" // CustomElementState
+#include "core/dom/custom/CEReactionsScope.h"
+#include "core/dom/custom/CustomElementDescriptor.h"
+#include "core/dom/custom/CustomElementReactionTestHelpers.h"
+#include "core/dom/custom/CustomElementTestHelpers.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+
+namespace {
+
+class ConstructorFails : public TestCustomElementDefinition {
+ WTF_MAKE_NONCOPYABLE(ConstructorFails);
+
+ public:
+ ConstructorFails(const CustomElementDescriptor& descriptor)
+ : TestCustomElementDefinition(descriptor) {}
+ ~ConstructorFails() override = default;
+ bool runConstructor(Element*) override { return false; }
+};
+
+} // namespace
+
+TEST(CustomElementDefinitionTest, upgrade_clearsReactionQueueOnFailure) {
+ Element* element = CreateElement("a-a");
+ EXPECT_EQ(CustomElementState::Undefined, element->getCustomElementState())
+ << "sanity check: this element should be ready to upgrade";
+ {
+ CEReactionsScope reactions;
+ reactions.enqueueToCurrentQueue(
+ element, new TestReaction({new Unreached(
+ "upgrade failure should clear the reaction queue")}));
+ ConstructorFails definition(CustomElementDescriptor("a-a", "a-a"));
+ definition.upgrade(element);
+ }
+ EXPECT_EQ(CustomElementState::Failed, element->getCustomElementState())
+ << "failing to construct should have set the 'failed' element state";
+}
+
+TEST(CustomElementDefinitionTest,
+ upgrade_clearsReactionQueueOnFailure_backupStack) {
+ Element* element = CreateElement("a-a");
+ EXPECT_EQ(CustomElementState::Undefined, element->getCustomElementState())
+ << "sanity check: this element should be ready to upgrade";
+ ResetCustomElementReactionStackForTest resetReactionStack;
+ resetReactionStack.stack().enqueueToBackupQueue(
+ element, new TestReaction({new Unreached(
+ "upgrade failure should clear the reaction queue")}));
+ ConstructorFails definition(CustomElementDescriptor("a-a", "a-a"));
+ definition.upgrade(element);
+ EXPECT_EQ(CustomElementState::Failed, element->getCustomElementState())
+ << "failing to construct should have set the 'failed' element state";
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698