third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js - Issue 2456773002: Clear the custom element's reaction queue if upgrade fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

Issue 2456773002: Clear the custom element's reaction queue if upgrade fails. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html ('k') | third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

diff --git a/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js b/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

index 50fe9722bcf7216a69e1243fe57c666f01e4720d..44871eebc43604f643334e41d47565b3f60a97e3 100644

--- a/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

+++ b/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

@@ -65,7 +65,7 @@ function assert_reports(w, expected_error, func, description) {

} finally {

w.onerror = old_onerror;

}

- assert_equals(1, errors.length);

+ assert_equals(errors.length, 1, 'only one error should have been reported');

// assert_throws has an error expectation matcher that can only be

// accessed by throwing the error

assert_throws(expected_error, () => { throw errors[0]; });