Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2455043002: Switch spelling marker from '_' to '#' in spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch spelling marker from '_' to '#' in spellcheck_test This patch makes spellcheck_test emits '#' instead of '_' as spelling marker, because there are some test cases manipulating text with underscores. This patch is a preparation for https://codereview.chromium.org/2459553002 BUG=517298 Committed: https://crrev.com/f058ce3b20561d60c8e71194febacae48fd01116 Cr-Commit-Position: refs/heads/master@{#428258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/context_click_on_selected_misspelling.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/design-mode-spellcheck-off.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/marker_preservation_with_focus_change.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/move-cursor-to-misspelled-word.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/paste_into_element_starting_with_invisible.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spelling_after_newline.html View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-28 02:07:20 UTC) #7
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-28 02:28:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455043002/1
4 years, 1 month ago (2016-10-28 02:28:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 02:34:41 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:36:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f058ce3b20561d60c8e71194febacae48fd01116
Cr-Commit-Position: refs/heads/master@{#428258}

Powered by Google App Engine
This is Rietveld 408576698