Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2458663002: Convert editing/spelling/spelling-insert-newline-between-multi-word-misspelling.html with spellchec… (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling-insert-newline-between-multi-word-misspelling.html with spellcheck_test This patch converts the layout test with spellcheck_test as a preparation for implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/6afbbe060222589a866bf1651fc413619e18241b Cr-Commit-Position: refs/heads/master@{#428294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -69 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spelling-insert-newline-between-multi-word-misspelling.html View 1 chunk +18 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-insert-newline-between-multi-word-misspelling-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-28 02:29:48 UTC) #7
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-28 06:08:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458663002/1
4 years, 1 month ago (2016-10-28 06:08:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 06:13:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 06:15:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6afbbe060222589a866bf1651fc413619e18241b
Cr-Commit-Position: refs/heads/master@{#428294}

Powered by Google App Engine
This is Rietveld 408576698