Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 2459553002: Convert editing/spelling/spelling-*-selection.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling-with-*-selection.html with spellcheck_test This patch converts the following tests with spellcheck_test: - editing/spelling/spelling-with-punctuation-selection.html - editing/spelling/spelling-with-underscore-selection.html - editing/spelling/spelling-with-whitespace-selection.html - editing/spelling/spelling-subword-selection.html - editing/spelling/spelling-multiword-selection.html The above tests are merged into context_click_on_selected_misspelling.html to better summarize the test cases. This patch is a preparation for implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/a7cc124d8d823153c8a66304910fc94ba773cf11 Cr-Commit-Position: refs/heads/master@{#428297}

Patch Set 1 #

Patch Set 2 : Also convert spelling-{subword,multiword}-selection.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -318 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/context_click_on_selected_misspelling.html View 1 3 chunks +52 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-multiword-selection.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-subword-selection.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-subword-selection-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-with-punctuation-selection.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-with-punctuation-selection-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-with-underscore-selection.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-with-underscore-selection-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-with-whitespace-selection.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-with-whitespace-selection-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-28 02:29:35 UTC) #11
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-28 06:07:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459553002/20001
4 years, 1 month ago (2016-10-28 06:08:09 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 06:16:25 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 06:18:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7cc124d8d823153c8a66304910fc94ba773cf11
Cr-Commit-Position: refs/heads/master@{#428297}

Powered by Google App Engine
This is Rietveld 408576698