Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 2455883003: Convert editing/spelling/spelling-huge-text.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling-huge-text.html with spellcheck_test This patch converts the layout test with spellcheck_test as a preparation for implementing idle time spellchecker. This patch also contains a performance optimization to spellcheck_test in handling CharacterData nodes with long text. BUG=517298 Committed: https://crrev.com/a00d926f0b0b20cf4e23fa5d4b848f52e0745850 Cr-Commit-Position: refs/heads/master@{#430211}

Patch Set 1 #

Patch Set 2 : Optimize spellcheck_test's handleCharacterData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js View 1 3 chunks +22 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spelling-huge-text.html View 1 1 chunk +11 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-huge-text-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-11-04 05:01:41 UTC) #9
yosin_UTC9
lgtm
4 years, 1 month ago (2016-11-07 01:44:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455883003/20001
4 years, 1 month ago (2016-11-07 01:44:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 02:37:25 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 02:39:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a00d926f0b0b20cf4e23fa5d4b848f52e0745850
Cr-Commit-Position: refs/heads/master@{#430211}

Powered by Google App Engine
This is Rietveld 408576698