Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2450403004: Convert editing/spelling/spellcheck-editable-on-focus.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spellcheck-editable-on-focus.html with spellcheck_test This patch converts the layout test with spellcheck_test as a preparation for implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/cd5cf97b2514c761b4af6abfe01ebdb8cc92cf63 Cr-Commit-Position: refs/heads/master@{#428296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -72 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html View 1 chunk +41 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-28 02:30:09 UTC) #7
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-28 06:09:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450403004/1
4 years, 1 month ago (2016-10-28 06:09:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 06:15:21 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 06:18:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd5cf97b2514c761b4af6abfe01ebdb8cc92cf63
Cr-Commit-Position: refs/heads/master@{#428296}

Powered by Google App Engine
This is Rietveld 408576698