Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
3 years, 11 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. BUG=648775

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -1331 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/protocol-test.js View 1 chunk +0 lines, -129 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands-generation.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands-generation-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/layers/layer-canvas-log.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/layers/layer-replay-scale.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-loader.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-API-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-API-errors-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-protocol-errors.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-protocol-errors-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layers/LayerTreeModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 3 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js View 5 chunks +21 lines, -12 lines 2 comments Download
A + third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js View 14 chunks +220 lines, -247 lines 5 comments Download
A third_party/WebKit/Source/devtools/front_end/protocol/module.json View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Connections.js View 5 chunks +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 1 chunk +0 lines, -746 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js View 1 chunk +0 lines, -128 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 2450973002 Patch 1

Messages

Total messages: 3 (1 generated)
dgozman
Could you please take a look?
4 years, 1 month ago (2016-10-26 02:24:31 UTC) #2
caseq
4 years, 1 month ago (2016-10-26 23:43:20 UTC) #3 
lgtm

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js
(right):

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js:7: var
HostedMode = {};
nit: naming a namespace "...Mode" is somewhat weird -- perhaps
HostedModeSupport?

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js:27:
HostedMode.toTitleCase = function(s)
..._toTitleCase(), i.e. private?

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js (right):

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js:69:
Protocol.Connection.Params;
Let's make it an interface instead.

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js:154:
Protocol._DisconnectedErrorCode = -32000;
Let's move it up to the rest of error code -- perhaps even one day turn into an
enum?

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js:210:
Protocol._agentPrototype = function(domain)
So we now have Protocol._agentPrototype, Protocol._angetPrototypes and
Protocol._AgentPrototype. Let's perhaps rename at least the latter, you're
touching its namespace anyway and we generally don't name classes with an
underscore.

This one could become Protocol._agentPrototypeForDomain()

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js:308: var
result = {methodName: method, domain: domain, callback: callback,
sendRequestTime: undefined};
nit: drop sendRequestTime?

https://codereview.chromium.org/2453673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js:447: var
callbacks = Array.from(this._callbacks.values());
You don't need a copy here, just iterate over values.

Powered by Google App Engine
This is Rietveld 408576698