Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js

Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js b/third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js
similarity index 78%
rename from third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
rename to third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js
index 8550ba2fef9b440b2a54665c1b8ea10caa06f830..79e576447929c4d0cdf4a46f18d937434e7c651c 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
+++ b/third_party/WebKit/Source/devtools/front_end/protocol/HostedMode.js
@@ -2,29 +2,38 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// This should be executed immediately after InspectorBackend and InspectorBackendCommands
+// This should be executed immediately after Protocol and InspectorBackendCommands
-WebInspector.InspectorBackendHostedMode = {};
+var HostedMode = {};
caseq 2016/10/26 23:43:20 nit: naming a namespace "...Mode" is somewhat weir
-WebInspector.InspectorBackendHostedMode.loadFromJSONIfNeeded = function()
+HostedMode.loadFromJSONIfNeeded = function()
{
- if (InspectorBackend.isInitialized())
+ if (Protocol.isInitialized())
return;
for (var url of Object.keys(Runtime.cachedResources)) {
if (url.indexOf("protocol.json") !== -1) {
var protocol = Runtime.cachedResources[url];
- var code = WebInspector.InspectorBackendHostedMode.generateCommands(JSON.parse(protocol));
+ var code = HostedMode.generateCommands(JSON.parse(protocol));
eval(code);
}
}
};
/**
+ * @param {string} s
+ * @return {string}
+ */
+HostedMode.toTitleCase = function(s)
caseq 2016/10/26 23:43:20 ..._toTitleCase(), i.e. private?
+{
+ return s.substring(0, 1).toUpperCase() + s.substring(1);
+};
+
+/**
* @param {*} schema
* @return {string}
*/
-WebInspector.InspectorBackendHostedMode.generateCommands = function(schema)
+HostedMode.generateCommands = function(schema)
{
var jsTypes = { integer: "number", array: "object" };
var rawTypes = {};
@@ -54,11 +63,11 @@ WebInspector.InspectorBackendHostedMode.generateCommands = function(schema)
prefix = "Negative";
name = name.substring(1);
}
- name = name.replace(/-(\w)/g, toUpperCase.bind(null, 1)).toTitleCase();
+ name = HostedMode.toTitleCase(name.replace(/-(\w)/g, toUpperCase.bind(null, 1)));
name = name.replace(/HTML|XML|WML|API/ig, toUpperCase.bind(null, 0));
members.push(prefix + name + ": \"" + value + "\"");
}
- return "InspectorBackend.registerEnum(\"" + enumName + "\", {" + members.join(", ") + "});";
+ return "Protocol.registerEnum(\"" + enumName + "\", {" + members.join(", ") + "});";
}
for (var i = 0; i < domains.length; ++i) {
@@ -74,7 +83,7 @@ WebInspector.InspectorBackendHostedMode.generateCommands = function(schema)
for (var k = 0; k < properties.length; ++k) {
var property = properties[k];
if ((property["type"] === "string") && property["enum"])
- result.push(generateEnum(domain.domain + "." + type.id + property["name"].toTitleCase(), property["enum"]));
+ result.push(generateEnum(domain.domain + "." + type.id + HostedMode.toTitleCase(property["name"]), property["enum"]));
}
}
}
@@ -109,7 +118,7 @@ WebInspector.InspectorBackendHostedMode.generateCommands = function(schema)
returnsText.push("\"" + parameter.name + "\"");
}
var hasErrorData = String(Boolean(command.error));
- result.push("InspectorBackend.registerCommand(\"" + domain.domain + "." + command.name + "\", [" + paramsText.join(", ") + "], [" + returnsText.join(", ") + "], " + hasErrorData + ");");
+ result.push("Protocol.registerCommand(\"" + domain.domain + "." + command.name + "\", [" + paramsText.join(", ") + "], [" + returnsText.join(", ") + "], " + hasErrorData + ");");
}
for (var j = 0; domain.events && j < domain.events.length; ++j) {
@@ -119,10 +128,10 @@ WebInspector.InspectorBackendHostedMode.generateCommands = function(schema)
var parameter = event.parameters[k];
paramsText.push("\"" + parameter.name + "\"");
}
- result.push("InspectorBackend.registerEvent(\"" + domain.domain + "." + event.name + "\", [" + paramsText.join(", ") + "]);");
+ result.push("Protocol.registerEvent(\"" + domain.domain + "." + event.name + "\", [" + paramsText.join(", ") + "]);");
}
}
return result.join("\n");
};
-WebInspector.InspectorBackendHostedMode.loadFromJSONIfNeeded();
+HostedMode.loadFromJSONIfNeeded();

Powered by Google App Engine
This is Rietveld 408576698