third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js - Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/protocol/Protocol.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/Target.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

index b0750a35c3a56ec8735a6f22f0e9e52b95a033cc..6922b8b017fea59196e30055b4490dd9f979e4bb 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

@@ -173,8 +173,8 @@ WebInspector.SubTargetsManager.prototype = {

/**

* @param {string} targetId

- * @param {!InspectorBackendClass.Connection.Params} params

- * @return {!InspectorBackendClass.Connection}

+ * @param {!Protocol.Connection.Params} params

+ * @return {!Protocol.Connection}

_createConnection: function(targetId, params)

{

@@ -290,10 +290,10 @@ WebInspector.SubTargetsDispatcher.prototype = {

/**

* @constructor

- * @implements {InspectorBackendClass.Connection}

+ * @implements {Protocol.Connection}

* @param {!Protocol.TargetAgent} agent

* @param {string} targetId

- * @param {!InspectorBackendClass.Connection.Params} params

+ * @param {!Protocol.Connection.Params} params

WebInspector.SubTargetConnection = function(agent, targetId, params)

{