Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html
diff --git a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html
index c12ae82128362a1e20e739db6374cd2ed55bbd83..e6db9645c2540a99d4b9e3111d49b390e3aeb727 100644
--- a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html
+++ b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html
@@ -23,15 +23,15 @@ function test()
var targets = WebInspector.targetManager.targets();
targets.forEach(function(target) {
- var agentNames = Object.keys(target._agents).filter(function(agentName) {
- var agent = target._agents[agentName];
+ var agentNames = Array.from(target._agents.keys()).filter(function(agentName) {
+ var agent = target._agents.get(agentName);
return agent["enable"] && agent["disable"] && agentName !== "ServiceWorker" && agentName !== "Security" && agentName !== "Inspector" && agentName !== "Target"; // async wrt others.
}).sort();
function disableAgent(agentName)
{
++requestsSent;
- var agent = target._agents[agentName];
+ var agent = target._agents.get(agentName);
agent.disable(finishWhenDone.bind(null, agentName, "disable"))
.catch(finishWhenDone.bind(null, agentName, "disable"));
}
@@ -39,7 +39,7 @@ function test()
function enableAgent(agentName)
{
++requestsSent;
- var agent = target._agents[agentName];
+ var agent = target._agents.get(agentName);
agent.enable(finishWhenDone.bind(null, agentName, "enable"))
.catch(finishWhenDone.bind(null, agentName, "enable"));
}

Powered by Google App Engine
This is Rietveld 408576698