Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2450973002: [DevTools] Inherit WI.Target from Protocol.Target. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Inherit WI.Target from Protocol.Target. Fixed compilation in multiple places. BUG=648775 Committed: https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03 Cr-Commit-Position: refs/heads/master@{#427563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -155 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/cached-sync-computed-styles.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-loader.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-API-errors.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Color.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 21 chunks +63 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 6 chunks +7 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py View 4 chunks +3 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 1 month ago (2016-10-25 21:25:35 UTC) #2
pfeldman
lgtm
4 years, 1 month ago (2016-10-25 22:35:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450973002/1
4 years, 1 month ago (2016-10-25 23:42:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 01:23:42 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 01:26:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03
Cr-Commit-Position: refs/heads/master@{#427563}

Powered by Google App Engine
This is Rietveld 408576698