Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2451613005: Format GN files and add a presubmit check that GN is properly formatted (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Format GN files and add a presubmit check that GN is properly formatted R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c1313a5ec754aa51eb226610f8521e4353f0b072

Patch Set 1 #

Patch Set 2 : Fix gn args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+629 lines, -570 lines) Patch
M BUILD.gn View 4 chunks +45 lines, -39 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 6 chunks +5 lines, -9 lines 0 comments Download
M build/config/mac/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/BUILD.gn View 1 chunk +3 lines, -8 lines 0 comments Download
M runtime/BUILD.gn View 12 chunks +55 lines, -73 lines 0 comments Download
M runtime/PRESUBMIT.py View 1 chunk +8 lines, -2 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 25 chunks +221 lines, -215 lines 0 comments Download
M runtime/bin/zlib/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/observatory/BUILD.gn View 4 chunks +14 lines, -15 lines 0 comments Download
M runtime/third_party/double-conversion/src/BUILD.gn View 2 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/BUILD.gn View 6 chunks +224 lines, -142 lines 0 comments Download
M third_party/tcmalloc/BUILD.gn View 4 chunks +24 lines, -28 lines 0 comments Download
M tools/gn.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M utils/compiler/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M utils/dartanalyzer/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
M utils/dartdevc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M utils/dartdoc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M utils/dartfmt/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M utils/pub/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-10-26 09:42:29 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-10-26 10:25:54 UTC) #3
zra
4 years, 1 month ago (2016-10-26 15:50:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c1313a5ec754aa51eb226610f8521e4353f0b072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698