Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: BUILD.gn

Issue 2451613005: Format GN files and add a presubmit check that GN is properly formatted (Closed)
Patch Set: Fix gn args Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index a7d7e22adc39a23c521ec9c64a217f58f2f18992..5055ecbb0445f5d053bc0bed7a5cb80ef099d941 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -25,33 +25,32 @@ group("runtime") {
deps = [
"runtime/bin:dart",
"runtime/bin:dart_bootstrap($host_toolchain)",
- "runtime/bin:run_vm_tests",
"runtime/bin:process_test",
- "runtime/bin:test_extension",
+ "runtime/bin:run_vm_tests",
"runtime/bin:sample_extension",
+ "runtime/bin:test_extension",
]
}
group("runtime_precompiled") {
deps = [
- "runtime/bin:dart_precompiled_runtime",
"runtime/bin:dart_bootstrap($host_toolchain)",
+ "runtime/bin:dart_precompiled_runtime",
]
}
group("runtime_and_noopt") {
deps = [
"runtime/bin:dart",
- "runtime/bin:dart_noopt",
"runtime/bin:dart_bootstrap($host_toolchain)",
- "runtime/bin:run_vm_tests",
+ "runtime/bin:dart_noopt",
"runtime/bin:process_test",
- "runtime/bin:test_extension",
+ "runtime/bin:run_vm_tests",
"runtime/bin:sample_extension",
+ "runtime/bin:test_extension",
]
}
-
action("create_sdk") {
deps = [
"runtime/bin:dart",
@@ -68,35 +67,43 @@ action("create_sdk") {
]
sdk_lib_files = exec_script("tools/list_dart_files.py",
- [rebase_path("sdk/lib")],
- "list lines")
+ [ rebase_path("sdk/lib") ],
+ "list lines")
- preamble_files = exec_script("tools/list_files.py",
- ["", rebase_path("sdk/lib/_internal/js_runtime/lib/preambles")],
- "list lines")
+ preamble_files =
+ exec_script("tools/list_files.py",
+ [
+ "",
+ rebase_path("sdk/lib/_internal/js_runtime/lib/preambles"),
+ ],
+ "list lines")
sdk_bin_files = exec_script("tools/list_files.py",
- ["", rebase_path("sdk/bin")],
- "list lines")
+ [
+ "",
+ rebase_path("sdk/bin"),
+ ],
+ "list lines")
inputs = rebase_path(sdk_lib_files, "", "sdk/lib") +
- rebase_path(preamble_files, "", "sdk/lib") +
- rebase_path(sdk_bin_files, "", "sdk/bin") + [
- "sdk/lib/dart_client.platform",
- "sdk/lib/dart_server.platform",
- "sdk/lib/dart_shared.platform",
- "$root_gen_dir/dart2js.dart.snapshot",
- "$root_gen_dir/utils_wrapper.dart.snapshot",
- "$root_gen_dir/pub.dart.snapshot",
- "$root_gen_dir/dartanalyzer.dart.snapshot",
- "$root_gen_dir/dartdevc.dart.snapshot",
- "$root_gen_dir/dartfmt.dart.snapshot",
- "$root_gen_dir/analysis_server.dart.snapshot",
- "$root_gen_dir/dartdoc.dart.snapshot",
- "$root_gen_dir/spec.sum",
- "$root_gen_dir/strong.sum",
- "tools/VERSION"
- ]
+ rebase_path(preamble_files, "", "sdk/lib") +
+ rebase_path(sdk_bin_files, "", "sdk/bin") +
+ [
+ "sdk/lib/dart_client.platform",
+ "sdk/lib/dart_server.platform",
+ "sdk/lib/dart_shared.platform",
+ "$root_gen_dir/dart2js.dart.snapshot",
+ "$root_gen_dir/utils_wrapper.dart.snapshot",
+ "$root_gen_dir/pub.dart.snapshot",
+ "$root_gen_dir/dartanalyzer.dart.snapshot",
+ "$root_gen_dir/dartdevc.dart.snapshot",
+ "$root_gen_dir/dartfmt.dart.snapshot",
+ "$root_gen_dir/analysis_server.dart.snapshot",
+ "$root_gen_dir/dartdoc.dart.snapshot",
+ "$root_gen_dir/spec.sum",
+ "$root_gen_dir/strong.sum",
+ "tools/VERSION",
+ ]
outputs = [
"$root_out_dir/dart-sdk/README",
@@ -111,34 +118,33 @@ action("create_sdk") {
]
}
-
group("dart2js") {
deps = [
- "utils/compiler:dart2js"
+ "utils/compiler:dart2js",
]
}
group("dartanalyzer") {
deps = [
- "utils/dartanalyzer"
+ "utils/dartanalyzer",
]
}
group("dartdevc") {
deps = [
- "utils/dartdevc"
+ "utils/dartdevc",
]
}
group("dartfmt") {
deps = [
- "utils/dartfmt"
+ "utils/dartfmt",
]
}
group("analysis_server") {
deps = [
- "utils/analysis_server"
+ "utils/analysis_server",
]
}
@@ -147,12 +153,12 @@ group("analysis_server") {
# test suites.
group("dart2js_bot") {
deps = [
- ":create_sdk"
+ ":create_sdk",
]
}
group("samples") {
deps = [
- "runtime/bin:sample_extension"
+ "runtime/bin:sample_extension",
]
}
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698