tools/gn.py - Issue 2451613005: Format GN files and add a presubmit check that GN is properly formatted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn.py

Issue 2451613005: Format GN files and add a presubmit check that GN is properly formatted (Closed)

Patch Set: Fix gn args Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn.py

diff --git a/tools/gn.py b/tools/gn.py

index 19bc1f6be587e6a847b0f1613183af1fc08ad117..6155b8d2f2362e4ba8df43387ab8fb7c5abc354e 100755

--- a/tools/gn.py

+++ b/tools/gn.py

@@ -91,7 +91,8 @@ def to_gn_args(args, mode, arch, target_os):

gn_args['dart_use_tcmalloc'] = (gn_args['target_os'] == 'linux'

and not args.asan)

- gn_args['arm_float_abi'] = 'hard'

+ if gn_args['target_cpu'].startswith('arm'):

+ gn_args['arm_float_abi'] = 'hard'

gn_args['is_debug'] = mode == 'debug'

gn_args['is_release'] = mode == 'release'

« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | utils/compiler/BUILD.gn » ('j') | no next file with comments »