Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: runtime/observatory/BUILD.gn

Issue 2451613005: Format GN files and add a presubmit check that GN is properly formatted (Closed)
Patch Set: Fix gn args Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/zlib/BUILD.gn ('k') | runtime/third_party/double-conversion/src/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/BUILD.gn
diff --git a/runtime/observatory/BUILD.gn b/runtime/observatory/BUILD.gn
index fc7af6a8b788af9aa49d1abbbc3ef1e246cee6d3..5058eed80c26854096b03f541a929d7435b98d50 100644
--- a/runtime/observatory/BUILD.gn
+++ b/runtime/observatory/BUILD.gn
@@ -16,15 +16,12 @@ declare_args() {
# Helper build rules for packaging the Dart observatory resources.
observatory_sources_gypi =
exec_script("../../tools/gypi_to_gn.py",
- [ rebase_path(
- "../observatory/observatory_sources.gypi") ],
+ [ rebase_path("../observatory/observatory_sources.gypi") ],
"scope",
[ "../observatory/observatory_sources.gypi" ])
copy("copy_observatory") {
- sources = rebase_path(observatory_sources_gypi.sources,
- "",
- ".")
+ sources = rebase_path(observatory_sources_gypi.sources, "", ".")
outputs = [
"$root_gen_dir/observatory_copy/{{source_root_relative_dir}}/{{source_file_part}}",
]
@@ -51,8 +48,7 @@ action("write_observatory_pubspec_yaml") {
"--command",
"rewrite",
rebase_path("../observatory/pubspec.yaml"),
- rebase_path(
- "$root_gen_dir/observatory_copy/$current_dir/pubspec.yaml"),
+ rebase_path("$root_gen_dir/observatory_copy/$current_dir/pubspec.yaml"),
"../../third_party/",
rebase_path("../../third_party/"),
]
@@ -94,10 +90,9 @@ action("copy_observatory_deps") {
action("pub_build_observatory") {
current_dir = rebase_path(".", "//")
- sources =
- rebase_path(observatory_sources_gypi.sources,
- "",
- "$root_gen_dir/observatory_copy/$current_dir")
+ sources = rebase_path(observatory_sources_gypi.sources,
+ "",
+ "$root_gen_dir/observatory_copy/$current_dir")
deps = [
":copy_observatory",
@@ -184,10 +179,14 @@ template("observatory_archive") {
rebase_path("$root_gen_dir/observatory/${output_name}.cc"),
"--tar_output",
rebase_path("$root_gen_dir/observatory/${output_name}.tar"),
- "--outer_namespace", outer_namespace,
- "--inner_namespace", inner_namespace,
- "--name", "observatory_assets_archive",
- "--client_root", rebase_path("$root_out_dir/observatory/deployed/web/"),
+ "--outer_namespace",
+ outer_namespace,
+ "--inner_namespace",
+ inner_namespace,
+ "--name",
+ "observatory_assets_archive",
+ "--client_root",
+ rebase_path("$root_out_dir/observatory/deployed/web/"),
]
if (enable_compression) {
args += [ "--compress" ]
« no previous file with comments | « runtime/bin/zlib/BUILD.gn ('k') | runtime/third_party/double-conversion/src/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698