Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/PRESUBMIT.py

Issue 2451613005: Format GN files and add a presubmit check that GN is properly formatted (Closed)
Patch Set: Fix gn args Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/BUILD.gn ('k') | runtime/bin/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/PRESUBMIT.py
diff --git a/runtime/PRESUBMIT.py b/runtime/PRESUBMIT.py
index f67f0d6952da966ef05c64d5d9831d6a8ee6c37a..946f54f96328d720ace0e3ee5cda4dbb85c211b1 100644
--- a/runtime/PRESUBMIT.py
+++ b/runtime/PRESUBMIT.py
@@ -44,9 +44,15 @@ def RunLint(input_api, output_api):
return result
+def CheckGn(input_api, output_api):
+ return input_api.canned_checks.CheckGNFormatted(input_api, output_api)
+
+
def CheckChangeOnUpload(input_api, output_api):
- return RunLint(input_api, output_api)
+ return (RunLint(input_api, output_api) +
+ CheckGn(input_api, output_api))
def CheckChangeOnCommit(input_api, output_api):
- return RunLint(input_api, output_api)
+ return (RunLint(input_api, output_api) +
+ CheckGn(input_api, output_api))
« no previous file with comments | « runtime/BUILD.gn ('k') | runtime/bin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698