Get rid of EditCommand::setEndingSelection() taking one VisiblePosition

Get rid of EditCommand::setEndingSelection() taking one VisiblePosition

This patch gets rid of |EditCommand::setEndingSelection()| taking one
|VisiblePosition| to reduce usage of |VisiblePosition| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/756e72cd34c840d8d2f22702b0c65984efddaca6
Cr-Commit-Position: refs/heads/master@{#427646}

[yosin_UTC9, 2016-10-26 05:35:03]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 05:35:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-26 06:13:56]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 06:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-26 07:26:37]

Description was changed from

==========
2016-10-26T14:32:48

BUG=
==========

to

==========
Get rid of EditCommand::setEndingSelection() taking one VisiblePosition

This patch gets rid of |EditCommand::setEndingSelection()| taking one
|VisiblePosition| to reduce usage of |VisiblePosition| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-26 07:27:38]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-26 07:27:41]

PTAL

Intentionally not to check null VisiblePosition to catch a such case by
ClusterFuzz.

[Xiaocheng, 2016-10-26 07:33:23]

One of the removed removed layout update calls still seems necessary.

https://codereview.chromium.org/2451093002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
(left):

https://codereview.chromium.org/2451093002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp:1252:
document().updateStyleAndLayoutIgnorePendingStylesheets();
previousPositionOf(VP) also requires clean layout.

[yosin_UTC9, 2016-10-26 07:40:22]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-26 07:41:02]

PTAL

PS#3 is as same as PS#1. I over killed update layout call in PS#2.

https://codereview.chromium.org/2451093002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
(left):

https://codereview.chromium.org/2451093002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp:1252:
document().updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/26 at 07:33:23, Xiaocheng wrote:
> previousPositionOf(VP) also requires clean layout.

Done. 
I have it in PS#1, then I removed in PS#2. (T_T)

[Xiaocheng, 2016-10-26 08:04:26]

lgtm

[yosin_UTC9, 2016-10-26 08:06:21]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-10-26 08:06:25]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-26 08:06:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 09:09:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 09:12:13]

Description was changed from

==========
Get rid of EditCommand::setEndingSelection() taking one VisiblePosition

This patch gets rid of |EditCommand::setEndingSelection()| taking one
|VisiblePosition| to reduce usage of |VisiblePosition| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Get rid of EditCommand::setEndingSelection() taking one VisiblePosition

This patch gets rid of |EditCommand::setEndingSelection()| taking one
|VisiblePosition| to reduce usage of |VisiblePosition| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/756e72cd34c840d8d2f22702b0c65984efddaca6
Cr-Commit-Position: refs/heads/master@{#427646}
==========

[commit-bot: I haz the power, 2016-10-26 09:12:14]

Patchset 3 (id:??) landed as
https://crrev.com/756e72cd34c840d8d2f22702b0c65984efddaca6
Cr-Commit-Position: refs/heads/master@{#427646}