Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 2451093002: Get rid of EditCommand::setEndingSelection() taking one VisiblePosition (Closed)
Patch Set: 2016-10-26T16:39:39 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.h b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
index 3e95154faa3676ac22871bff6864e84c387c0876..57b2d92708a26b94432ae3d21db81445a70c4306 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
@@ -72,7 +72,6 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
// TODO(yosin): We should get rid of overloads of |setEndingSelection()|
// except for taking |SelectionInDOMTree|.
void setEndingSelection(const VisibleSelection&);
- void setEndingSelection(const VisiblePosition&);
// TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
// |VisiblePosition::characterAfter()| and
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698