Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 2451093002: Get rid of EditCommand::setEndingSelection() taking one VisiblePosition (Closed)
Patch Set: 2016-10-26T16:39:39 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 protected: 65 protected:
66 explicit EditCommand(Document&); 66 explicit EditCommand(Document&);
67 67
68 Document& document() const { return *m_document.get(); } 68 Document& document() const { return *m_document.get(); }
69 CompositeEditCommand* parent() const { return m_parent; } 69 CompositeEditCommand* parent() const { return m_parent; }
70 void setStartingSelection(const VisibleSelection&); 70 void setStartingSelection(const VisibleSelection&);
71 void setEndingSelection(const SelectionInDOMTree&); 71 void setEndingSelection(const SelectionInDOMTree&);
72 // TODO(yosin): We should get rid of overloads of |setEndingSelection()| 72 // TODO(yosin): We should get rid of overloads of |setEndingSelection()|
73 // except for taking |SelectionInDOMTree|. 73 // except for taking |SelectionInDOMTree|.
74 void setEndingSelection(const VisibleSelection&); 74 void setEndingSelection(const VisibleSelection&);
75 void setEndingSelection(const VisiblePosition&);
76 75
77 // TODO(yosin) |isRenderedCharacter()| should be removed, and we should use 76 // TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
78 // |VisiblePosition::characterAfter()| and 77 // |VisiblePosition::characterAfter()| and
79 // |VisiblePosition::characterBefore()|. 78 // |VisiblePosition::characterBefore()|.
80 static bool isRenderedCharacter(const Position&); 79 static bool isRenderedCharacter(const Position&);
81 80
82 private: 81 private:
83 Member<Document> m_document; 82 Member<Document> m_document;
84 VisibleSelection m_startingSelection; 83 VisibleSelection m_startingSelection;
85 VisibleSelection m_endingSelection; 84 VisibleSelection m_endingSelection;
(...skipping 19 matching lines...) Expand all
105 104
106 DEFINE_TYPE_CASTS(SimpleEditCommand, 105 DEFINE_TYPE_CASTS(SimpleEditCommand,
107 EditCommand, 106 EditCommand,
108 command, 107 command,
109 command->isSimpleEditCommand(), 108 command->isSimpleEditCommand(),
110 command.isSimpleEditCommand()); 109 command.isSimpleEditCommand());
111 110
112 } // namespace blink 111 } // namespace blink
113 112
114 #endif // EditCommand_h 113 #endif // EditCommand_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698